TTT: Fix a small issue and remove some unused things #1218

Merged
merged 2 commits into from Jul 29, 2016

Projects

None yet

4 participants

@markusmarkusz
Contributor

Changes made:

  • removed SWEP.LimitedStock because it's no longer buyable.
  • removed SWEP:RemovePlayerSample because it's no longer used.
  • removed unused if-query.
  • removed unused sound.
  • added LANG.TryTranslation to safely fix a issue in dna tooltip. Otherwise you can see for example "DNA sample found on pistol_name"

What about making names of the some variables general?
For example rename SWEP.ItemSamples to SWEP.Samples?
These changes aren't really needed so I haven't add them to this PR.
Should these changes be made?

@willox
Collaborator
willox commented Jul 27, 2016

For example rename SWEP.ItemSamples to SWEP.Samples?

You're probably best off trying to never rename anything that could be accessed by third-party scripts. You'd be surprised how often people rely on them.

@markusmarkusz
Contributor

@willox
Okay. I knew that this could happen.
This was the reason why I asked this.

@robotboy655 robotboy655 added the TTT label Jul 27, 2016
@markusmarkusz
Contributor

Changes made:

  • removed unused LANG.GetTranslation
  • removed unused LANG.GetParamTranslation
  • added local variable for LANG.TryTranslation (Is this useful or not?)
@markusmarkusz markusmarkusz changed the title from TTT: Fix a small issue and removed unused things to TTT: Fix a small issue and remove some unused things Jul 27, 2016
@svdm
Collaborator
svdm commented Jul 29, 2016

Indeed, I've often wanted to rename a bunch of stuff to be more clean and consistent (especially the GAMEMODE.* stuff in init.lua) but it will inevitably break a bunch of people's stuff, so it's not worth it.

@svdm svdm merged commit 56c72e5 into garrynewman:master Jul 29, 2016
@markusmarkusz markusmarkusz deleted the unknown repository branch Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment