TTT: Remove unused things #1226

Merged
merged 1 commit into from Aug 7, 2016

Projects

None yet

3 participants

@markusmarkusz
Contributor

I hate GitHub.
I cannot reopen my old pull request.

So finally I'll never touch this hook (TTTDelayRoundStartForVote) again.
@Bo98 found some (in my opinion) very crazy coded mapvotes.
They use this hook. So indeed it seems like that there are people who use this hook.

About mapcycle:
I was a bit iritated because in the ttt home page it says:

ttt_always_use_mapcycle (def. 0):
Enables the use of your mapcycle.txt even if voting is enabled. Since GMod 13 no voting exists (at the time of writing), so this does nothing.

And in mapcycle.txt it says:

It is empty because Garry's Mod does not use mapcycle.txt
It only exists so that mapcycle.txt from mountable games ( Portal 2 ) does not load and spam the console with errors

So I thought in isn't really used and I didn't thought about this.
But game.GetMapNext() checks mapcycle.txt
So mapcycle is used in TTT.

Anyway these changes can be made:

  • Removing this if-query in cl_voice.lua
  • Removing "ttt_announce_deaths"-ConVar
  • Removing "ttt_always_use_mapcycle"-ConVar

These things are really not used.
(My old PRs: #1225 and #1223 )

Next time I will take more time for chaning something. So I can test it and search the internet about it.
I apologize if I confused someone. :(

@robotboy655 robotboy655 added the TTT label Aug 5, 2016
@svdm svdm merged commit 54aeb7e into garrynewman:master Aug 7, 2016
@markusmarkusz markusmarkusz deleted the unknown repository branch Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment