Made UTIL_IsUselessModel more efficient #818

Merged
merged 3 commits into from Mar 26, 2015

Projects

None yet

4 participants

@Kefta
Contributor
Kefta commented Sep 28, 2014

No description provided.

@SimonSchick
Contributor

Add ,1, true please, that would should make it even faster.

@Kefta
Contributor
Kefta commented Sep 28, 2014

Add what now?

@SimonSchick
Contributor

str:find(needle, 1, true) disables pattern search.

@AshleighAdams
Contributor

Also ipairs?

@robotboy655
Collaborator

And perhaps rename the function to util.IsUselessModel and add UTIL_IsUselessModel = util.IsUselessModel for now.

@Kefta
Contributor
Kefta commented Sep 28, 2014

Is ipairs really necessary for a table with three values? The speed difference is negligible.

@Kefta
Contributor
Kefta commented Sep 28, 2014

You sure you want it util.IsUselessModel and not just IsUselessModel? Nothing else in that file is a util. function.

@robotboy655
Collaborator

Good point, I guess IsUselessModel makes more sense.

@Kefta
Contributor
Kefta commented Sep 28, 2014

#805
:(

@robotboy655
Collaborator

I know I know, I was wrong.

You should stop adding hundreds of commits to a single PR tho.

@Kefta
Contributor
Kefta commented Sep 29, 2014

Yeah, I notice I do that too. I'll try to start making more mass changes.

@Kefta
Contributor
Kefta commented Jan 4, 2015

Bump? No label on it yet either

@robotboy655
Collaborator

I am not merging anything until the update it out.

@robotboy655 robotboy655 merged commit 8ae503c into garrynewman:master Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment