Improved map counter when filtering maps #825

Merged
merged 1 commit into from Mar 31, 2015

Projects

None yet

2 participants

@Bo98
Contributor
Bo98 commented Oct 2, 2014

The previous CountFiltered function used regex instead of AngularJS's filter function, unlike the actual filterer. This lead to mismatches between the number of actual filtered maps and counter's number. This also fixes some errors that were being spammed in the case of invalid regex expressions being used in the search box.

@robotboy655
Collaborator

I think I accidentally fixed this with 72fe957

Do you still think we should change CountFiltered to your version?

@Bo98
Contributor
Bo98 commented Jan 19, 2015

I believe the change is still required.

Try searching !de in the Counter-Strike section.

I'll fix the merge conflict tomorrow.

@Bo98 Bo98 Improved map counter when filtering maps.
The previous CountFiltered function used regex instead of AngularJS's filter function, unlike the actual filterer. This lead to mismatches between the number of actual filtered maps and counter's number. This also fixes some errors that were being spammed in the case of invalid regex expressions being used in the search box.
106e215
@Bo98
Contributor
Bo98 commented Jan 20, 2015

Merge conflict is fixed now.

@robotboy655 robotboy655 merged commit ae265a3 into garrynewman:master Mar 31, 2015
@Bo98 Bo98 deleted the Bo98:countfiltered branch Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment