Properties can only be used on weapons when unheld #874

Merged
merged 1 commit into from Mar 26, 2015

Projects

None yet

3 participants

@willox
Collaborator
willox commented Feb 18, 2015

This stops people joining innocent prop-protection-less sandbox servers and
removing everybody's weapons.
Instead they can only instantly remove every prop on the map! Oh well.

The only alternative is saving right-click state server-side and that's quite gross.
Install prop-protection, kids.

@willox willox Properties can only be used on weapons when unheld
This stops people joining innocent prop-protection-less sandbox servers
and removing everybody's weapons.
Instead they can only instantly remove every prop on the map! Oh well.
c384a1c
@thegrb93
Contributor

I agree. Properties should be changed so that the server does a trace on the calling player instead of simply the player sending a net message with an entity. Any entity loaded on the map can be removed with a simple net message.

Personally, I would just do away with that system anyway. The toolgun is all we need in my opinion. On my server I have

hook.Add( "CanProperty", "block_properties", function( ply, property, ent )
    if property~="bodygroups" and property~="skin" then
        ply:ChatPrint("Property "..property.." is disabled.")
        return false
    end
end )
@robotboy655
Collaborator

@thegrb93, I tried the trace, didn't work. I guess adding a distance check can make it a little bit better

@willox
Collaborator
willox commented Feb 19, 2015

Either way you don't want people removing other people's physguns while they are using them :v

@robotboy655 robotboy655 added the pending label Feb 19, 2015
@robotboy655 robotboy655 merged commit fdab8ba into garrynewman:master Mar 26, 2015
@willox willox deleted the unknown repository branch Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment