Why on earth would you call Get twice here?
I'm happy to acknowledge that when my scripts load they will be free of a few unnecessary operations.
That sounds like sarcasm ಠ_ಠ
While I agree that this change is very minor - you don't know how people might be using this function. If you have a sent based on a sent based on a sent, You'll be calling Get 7 times instead of 3.
Edit: and besides, it's small things like this that add up, and sometimes you want your loading times to be faster. Notice how in sandbox the Q menu could take several seconds to open the first time you open it? It's in part because of this kind of nonsense.
Not that I care all that much :P
That still wouldn't be an issue. It's not a bad change, though. I'm all for good code.
SEntList[ name ].Base
If you're suggesting the if statement here isn't neccesary, I assume it's so that we don't get any infinite loops on base_entity (which is its own base as all entities must have a base).
I'm surprised, but this actually seems to be about 32-35% quicker.