Allow spectators to talk in all chat -- redirects to team #890

Merged
merged 3 commits into from May 24, 2015

Projects

None yet

5 participants

@Kefta
Contributor
Kefta commented Mar 10, 2015

Also, allows innos to use team chat. Both redirect to team chat and all chat respectively, but it's beneficial in situations such as a person getting killed while typing and they lose their message after they send it; or someone trying to quickly type who the killer is before they are killed, but they hit the wrong key.

This still supports the mumbling and spec all chat systems

Kefta added some commits Mar 10, 2015
@Kefta Kefta Allow spectators to talk in all chat -- redirects to team
Also, allows innos to use team chat. Both redirect to team chat and all chat respectively, but it's beneficial in situations such as a person getting killed while typing and they lose their message after they send it; or someone trying to quickly type who the killer is before they are killed, but they hit the wrong key.
f36990f
@Kefta Kefta Removed keys spec message 6bbfed6
@robotboy655 robotboy655 added the TTT label Mar 10, 2015
@svdm
Collaborator
svdm commented Mar 13, 2015

I like the idea. One thing though: what happens if I teamchat something like '"bla" ; kill', resulting in ply:ConCommand('say "bla" ; kill') being executed here?

@Jvs34
Jvs34 commented Mar 13, 2015

If code_gs replaces the ConCommand "say" and "say_team" with http://wiki.garrysmod.com/page/Player/Say then nothing would happen ( as in the commands don't get parsed at all )

@robotboy655
Collaborator

Wouldn't it be a better idea to just use http://wiki.garrysmod.com/page/GM/PlayerCanSeePlayersChat for this, and not some weird hacky workarounds?

@AshleighAdams
Contributor

@robotboy655 I agree; this shouldn't be incorporated using this method. If re-done properly--using the hook--then yes, this would be good.

@Kefta
Contributor
Kefta commented Mar 23, 2015

@svdm Ready to be merged

@Kefta
Contributor
Kefta commented May 24, 2015

@svdm Hello?

@svdm svdm merged commit 3fa638b into garrynewman:master May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment