Use PlayerModel colouring for TTT players #939

Merged
merged 2 commits into from May 2, 2015

Projects

None yet

7 participants

@DarthTealc
Contributor

Removes the need for checking if a playermodel is colourable as it uses GMod 13's matproxy player colouring.

@robotboy655 robotboy655 added the TTT label Apr 29, 2015
@robotboy655
Collaborator

It never did? Wow.

@svdm
Collaborator
svdm commented May 1, 2015

So just to make sure: playermodels without any sort of support for this will simply not get a colour?

@robotboy655
Collaborator

Yes. You can test this yourself by trying out a model that's not supporting this in sandbox.

@DarthTealc
Contributor

I've been using this (via a hook) for a few months on a live TTT server with additional playermodels (some colourable, some not, such as the arctic one that TTT uses already) and telling it that they're all colourable regardless of if they actually are or not (via TTTShouldColorModel) and haven't seen any issues.

@svdm svdm merged commit e76d25b into garrynewman:master May 2, 2015
@DarthTealc DarthTealc deleted the unknown repository branch May 3, 2015
@DetectDefective

Fair heads up; the corpse doesn't retain the coloring, it just reverts to default blue clothing.

Still, I'm super happy to see this being added.

@DarthTealc
Contributor

Corpses were not retaining colour anyway (at least on the server I work on), but I'm looking into a solution for that. Trying to avoid having to send a net message but it's looking like that's the way it needs to be done. I'll do a pull request soon if nobody beats me to it.

@JackTheRipper1806

Github Fucking sucks I have to individually download all of these fucking files!

Contributor

git clone

@ElektroPanda

Does this deal with the problem that causes traitor team glows to lag people ONLY when traitor? (the glow outline around your t buddies through walls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment