New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimum Perl version to Makefile.PL to improve kwalitee score #24

Merged
merged 1 commit into from Aug 6, 2015

Conversation

Projects
None yet
2 participants
@mnlagrasta
Contributor

mnlagrasta commented Aug 4, 2015

As far as I can tell, the minimum version could be 5.6.0 However, I chose 5.8.1 because this is required by cpanm and it seemed pointless to specify less than that.
This was done as part of CPAN Pull Request Challenge.

@mnlagrasta

This comment has been minimized.

Show comment
Hide comment
@mnlagrasta

mnlagrasta Aug 4, 2015

Contributor

Oops. I didn't check the outstanding pull requests before submitting mine. I think mine will replace #22 with no issues on the travis build.

Contributor

mnlagrasta commented Aug 4, 2015

Oops. I didn't check the outstanding pull requests before submitting mine. I think mine will replace #22 with no issues on the travis build.

garu added a commit that referenced this pull request Aug 6, 2015

Merge pull request #24 from mnlagrasta/mnl_kwalitee
Added minimum Perl version to Makefile.PL to improve kwalitee score

@garu garu merged commit 88a3daf into garu:master Aug 6, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 90.044%
Details
@garu

This comment has been minimized.

Show comment
Hide comment
@garu

garu Aug 6, 2015

Owner

Thanks! \o/

Owner

garu commented Aug 6, 2015

Thanks! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment