Browse files

removed (broken) support for Digest::Haval256

Turns out Digest::Haval256 support has been broken all the time.
Objects from this class can't really be observed without damaging
the original data. It didn't affect a lot of people since it's an
old module and doesn't even work on 64 bits (though there is a patch
available). If future versions provide a clone() function, it can
be added again.
  • Loading branch information...
1 parent 5f33e61 commit 4c0b0eaf24763116add7bad90d9da39a2061beb4 @garu committed Mar 16, 2013
Showing with 5 additions and 2 deletions.
  1. +3 −0 Changes
  2. +1 −1 lib/Data/Printer/Filter/Digest.pm
  3. +1 −1 t/13.3-filter_digest.t
View
3 Changes
@@ -9,6 +9,9 @@ Revision history for Data-Printer
BUG FIXES:
- fixed crash in esoteric classes (github issue #41, thanks
Ivan Bessarabov for reporting)
+ - removed support for Digest::Haval256, as it can't really be
+ observed without damaging the original data. If future versions
+ provide a clone() function, it can be added again.
OTHER:
- more tests
View
2 lib/Data/Printer/Filter/Digest.pm
@@ -4,7 +4,7 @@ use warnings;
use Data::Printer::Filter;
use Term::ANSIColor;
-foreach my $digest ( qw( Digest::MD2 Digest::MD4 Digest::Haval256)) {
+foreach my $digest ( qw(Digest::MD2 Digest::MD4) ) {
filter $digest => \&_print_digest;
}
View
2 t/13.3-filter_digest.t
@@ -19,7 +19,7 @@ my $data = 'I can has Digest?';
foreach my $module (qw( Digest::Adler32 Digest::MD2 Digest::MD4 Digest::MD5
Digest::SHA Digest::SHA1
- Digest::Whirlpool Digest::Haval256
+ Digest::Whirlpool
)) {
SKIP: {

0 comments on commit 4c0b0ea

Please sign in to comment.