New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three fixes to prevent test failures on cpantesters.org #66

Merged
merged 3 commits into from Dec 29, 2015

Conversation

Projects
None yet
2 participants
@bk
Contributor

bk commented May 31, 2015

These three commits are intended to address most of the current test failures on cpantesters.org, namely:

  1. sporadic failures with perl 5.12 and later on OS X.
  2. sporadic failures with 5.12 and later on older versions of Windows. (I was not actually able to reproduce the error on Windows, so the proposed test fix is something of a guess in this case).
  3. frequent failures with perl 5.8 on all platforms.

bk added some commits May 30, 2015

Use Package::Stash directly - don't require it in an eval block.
This prevents opaque and silent errors in t/05-obj.t in some Perl
versions on OS X.

Also, emit a warning if an unexpected error is encountered when
looking for superclasses or methods.
Prevent a class of errors on Perl 5.8 caused by the version module
These errors manifested as unexpected behaviour wrt what public and
private methods were seen for some objects. _VERSION (from version:vpp)
was seen as a private method, and import (from Exporter) was seen as a
public method even if Exporter had never been invoked. A typical test
failure illustrating this:

http://www.cpantesters.org/cpan/report/fea5031c-95c0-11e4-a8f0-281bc892881a

@bk bk referenced this pull request May 31, 2015

Closed

CPAN Pull Request Challenge #64

garu added a commit that referenced this pull request Dec 29, 2015

Merge pull request #66 from bk/cpantesters-fixes
Three fixes to prevent test failures on cpantesters.org

@garu garu merged commit 8bd4444 into garu:master Dec 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garu

This comment has been minimized.

Show comment
Hide comment
@garu

garu Dec 29, 2015

Owner

@bk thanks!

Owner

garu commented Dec 29, 2015

@bk thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment