Update _config.yml #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@dzach
Contributor

dzach commented Sep 22, 2012

Oops! This is a mistake, please disregard this pull request. I don't know how to delete it.

I am trying to figure out how to use the template for displaying some stl files but I still have troubles with the alternative method.

@garyhodgson

This comment has been minimized.

Show comment
Hide comment
@garyhodgson

garyhodgson Sep 22, 2012

Owner

No worries - give me a shout if I can be of help. My explanation of the alternative method might not be very clear.

Owner

garyhodgson commented Sep 22, 2012

No worries - give me a shout if I can be of help. My explanation of the alternative method might not be very clear.

@dzach

This comment has been minimized.

Show comment
Hide comment
@dzach

dzach Sep 22, 2012

Contributor

Thanks. It's probably me not getting it right with git. I'll create a test repository and try it again. In the meanwhile I have another issue which I'll submit separately.

Contributor

dzach commented Sep 22, 2012

Thanks. It's probably me not getting it right with git. I'll create a test repository and try it again. In the meanwhile I have another issue which I'll submit separately.

@dzach

This comment has been minimized.

Show comment
Hide comment
@dzach

dzach Sep 23, 2012

Contributor

I tried with another test project and I can't get it to work with the alternative method.
After installing jekyll I can run it locally without a problem, but not the pushed to GitHub version. Reading the GitHub help, it seems that the source: template setting is overridden by GitHub (last paragraph)

Contributor

dzach commented Sep 23, 2012

I tried with another test project and I can't get it to work with the alternative method.
After installing jekyll I can run it locally without a problem, but not the pushed to GitHub version. Reading the GitHub help, it seems that the source: template setting is overridden by GitHub (last paragraph)

@garyhodgson

This comment has been minimized.

Show comment
Hide comment
@garyhodgson

garyhodgson Sep 23, 2012

Owner

Ah, that's embarrassing. I added the alternative approach at the last minute and I had thought I had tested it deployed to github, but obviously I hadn't, and as you rightly point out it seems the source option is not available when deployed - annoying!

I'll update the readme and blog post to reflect this and will see if there is a fix because I think having a shared template as a submodule is quite useful.

Thanks for finding the bug, and sorry for not having tested it as deployed.

Owner

garyhodgson commented Sep 23, 2012

Ah, that's embarrassing. I added the alternative approach at the last minute and I had thought I had tested it deployed to github, but obviously I hadn't, and as you rightly point out it seems the source option is not available when deployed - annoying!

I'll update the readme and blog post to reflect this and will see if there is a fix because I think having a shared template as a submodule is quite useful.

Thanks for finding the bug, and sorry for not having tested it as deployed.

@dzach

This comment has been minimized.

Show comment
Hide comment
@dzach

dzach Sep 23, 2012

Contributor

Not at all, that's what open source is all about, isn't it? :-) I think this a excellent idea and implementation that adds value to GitHub.

Obviously GitHub wants user pages to be served from the gh-pages branch so that's probably why it overrides the source setting. Maybe the GitHub developers can be persuaded to accept a user defined source setting if it points to an existing submodule in a project.

Some kind of automatic template generation, similar to GitHub's Automatic Page Generator, could of course make the process more straight forward.

Contributor

dzach commented Sep 23, 2012

Not at all, that's what open source is all about, isn't it? :-) I think this a excellent idea and implementation that adds value to GitHub.

Obviously GitHub wants user pages to be served from the gh-pages branch so that's probably why it overrides the source setting. Maybe the GitHub developers can be persuaded to accept a user defined source setting if it points to an existing submodule in a project.

Some kind of automatic template generation, similar to GitHub's Automatic Page Generator, could of course make the process more straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment