Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adds possibilitiy to use Date + Number in Textbox #7

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@Alipoodle
Copy link
Contributor

commented Oct 6, 2019

While I'm aware of being able to use Custom Input's through Creating a element through JS. I wanted to allow for a simple way to expand on being able to use simple Input variations without the need to create fancy custom items through JS already.
As it's such a simple thing to add to this plugin I though of adding it.

One thing which might need to be done is a change of the use of IndexOf on line 486. I didn't read anywhere of the current supportability on Browsers, and decided to go with IE10+ being probably the most acceptable margin.

$.MessageBox({
    message : "<b>Here is a complex form with different input types!</b>",
    input   : {
        text     : { type : "text",      title : "Text"     },
        date     : { type : "date",      title : "Date"     },
        password : { type : "password",  title : "Password" },
        number   : { type : "number",    title : "Number"   }
    }
})
.done(function(data){ console.log(data); });

Side note:
Really enjoy this plugin and has been a complete saviour for me at my work for a simple way of getting informations in a nice looking design (with a few CSS Theming)

Alipoodle added 3 commits Oct 6, 2019
Allow for more types of Input
@gasparesganga

This comment has been minimized.

Copy link
Owner

commented Oct 7, 2019

Hi, thank you for your pull request!
Being in late 2019 with very decent browser support for new input types, this looks like a good idea indeed.
I'll merge it and tweak it a little bit in order to support more input types before releasing a new minor version.

Talking about CSS theming, it is something I have been thinking about, but I'm very bad with graphic design in general and moreover I'm pretty lazy with it.
If you wish you CSS theme(s) to be included, feel free to submit it/them! It would be great to have some messagebox.theme_xxx.css, messagebox.theme_yyy.css, messagebox.theme_zzz.css, etc. files shipped with the plugin. Of course the creator and maintainer of the theme will be credited for his/her work.

@gasparesganga gasparesganga merged commit fd87a16 into gasparesganga:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.