Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing to the API #517

Merged
merged 8 commits into from
May 9, 2024
Merged

Add tracing to the API #517

merged 8 commits into from
May 9, 2024

Conversation

smnmna99
Copy link
Collaborator

@smnmna99 smnmna99 commented Apr 27, 2024 •
edited by mostafa
Loading

Ticket(s)

Closes #186

Description

This PR adds tracing to API. It also add more logging.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa changed the title add logs Add tracing to the API May 3, 2024
@mostafa mostafa marked this pull request as ready for review May 9, 2024 16:03
mostafa
mostafa approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smnmna99,

Thanks for your contribution! 🙏

@mostafa mostafa force-pushed the API-monitoring-fix branch 2 times, most recently from 6f1833c to 0ca4b10 Compare May 9, 2024 18:06
@mostafa mostafa merged commit 1709235 into main May 9, 2024
3 of 4 checks passed
@mostafa mostafa deleted the API-monitoring-fix branch May 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafa mostafa mostafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tracing to API
2 participants
@smnmna99 @mostafa