Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Client ports description to "None configured" if no configured client ports #171

Merged
merged 1 commit into from Apr 6, 2018

Conversation

@sklirg
Copy link
Contributor

@sklirg sklirg commented Mar 30, 2018

This fixes a bug where "Client ports" value could be "0 / NaN" if no client ports were configured.

Client ports can be reported as 0 / NaN. The API might respond with information about number of live clients without information about total clients, if the number is 0. (Source: https://github.com/tech-server/gondul/blob/05e09f3b63269a48d1beb0dc9900b180101cec7f/web/api/public/switch-state#L28-L29 -- total is never initialized (but live is) and will therefore not exist in the json source if no client ports were configured for the switch.)

Before:
image

After:
image

Linge approves with love.

…ient ports.

This fixes a bug where "Client ports" value could be "0 / NaN" if no client ports were configured.
@KristianLyng KristianLyng merged commit d880cd2 into gathering:master Apr 6, 2018
@sklirg sklirg deleted the sklirg:patch-3 branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants