Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle: Remove maven central automatic configuration [BREAKING] #4259

Closed
Isammoc opened this issue Jun 17, 2022 · 1 comment · Fixed by gatling/gatling-gradle-plugin#56
Closed

Gradle: Remove maven central automatic configuration [BREAKING] #4259

Isammoc opened this issue Jun 17, 2022 · 1 comment · Fixed by gatling/gatling-gradle-plugin#56
Assignees
@Isammoc
Labels
Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin Type - Feature
Milestone
3.8.0

Comments

@Isammoc
Copy link
Member

Isammoc commented Jun 17, 2022

gatling-gradle-plugin currently adds the mavenCentral repository if gatling is not found.
But my opinion is that it's not the purpose of such plugin to add it.

On the other hand, we should add an explaining message when gatling dependency is absent with the suggestion code to add mavenCentral (but let the user decide if they want to add another repository, such as proxy in enterprise environment).
@Isammoc Isammoc added Type - Feature Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin labels Jun 17, 2022
@Isammoc Isammoc self-assigned this Jun 17, 2022
@slandelle slandelle changed the title [Gradle] Remove the addition of a repository [Gradle] Remove maven central automatic configuration Jun 17, 2022
@Isammoc
Copy link
Member Author

Isammoc commented Jun 17, 2022

Suggestion:

  • Remove repository addition (and corresponding flaky tests)
  • Continue to check for gatling dependency avalaibility, but fail the build with a clean message

@slandelle slandelle added this to the 3.8.0 milestone Jun 17, 2022
Isammoc added a commit to gatling/gatling-gradle-plugin that referenced this issue Jun 17, 2022
@Isammoc
feat: remove automatic maven central configuration, Closes gatling/ga…
0a5e0e9 
…tling#4259

Motivation:
Flaky tests and out of scope feature

Modifications:
 * Remove automatic maven central configuration
 * Display an explicit message when gatling dependencies are not reachable

Result:
Limit scope
Isammoc added a commit to gatling/gatling-gradle-plugin that referenced this issue Jun 17, 2022
@Isammoc
feat: remove automatic maven central configuration, #4259
c988aa0 
Motivation:
Flaky tests and out of scope feature

Modifications:
 * Remove automatic maven central configuration
 * Display an explicit message when gatling dependencies are not reachable

Result:
Limit scope

Closes gatling/gatling#4259
@Isammoc Isammoc mentioned this issue Jun 17, 2022
Merged
slandelle pushed a commit to gatling/gatling-gradle-plugin that referenced this issue Jun 17, 2022
@Isammoc @slandelle
feat: remove automatic maven central configuration, #4259
6ba5824 
Motivation:
Flaky tests and out of scope feature

Modifications:
 * Remove automatic maven central configuration
 * Display an explicit message when gatling dependencies are not reachable

Result:
Limit scope

Closes gatling/gatling#4259
@slandelle slandelle changed the title [Gradle] Remove maven central automatic configuration Gradle: Remove maven central automatic configuration Jun 20, 2022
@slandelle slandelle changed the title Gradle: Remove maven central automatic configuration Gradle: Remove maven central automatic configuration [BREAKING] Jul 4, 2022
@slandelle slandelle mentioned this issue Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Isammoc Isammoc

Labels
Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin Type - Feature
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

feat: remove automatic maven central configuration, #4259 gatling/gatling-gradle-plugin
2 participants
@Isammoc @slandelle