New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two issues in BytesInputStream.read #1564

Merged
merged 1 commit into from Dec 19, 2013

Conversation

Projects
None yet
2 participants
@froden
Copy link
Contributor

froden commented Dec 19, 2013

The check to determine if all bytes were read used the wrong length
variable (local instead of field). This potentially caused the stream to never
report eof and some stream operations would never terminate.

The check to prevent reading more bytes than available also used the
wrong lenght variable (local instead of field). This caused an
ArrayIndexOutOfBoudsException in System.arraycopy().

Fixed two issues in BytesInputStream.read
The check to determine if all bytes were read used the wrong length
variable (local instead of field). This caused the stream to never
report eof and some stream operations would never terminate.

The check to prevent reading more bytes than available also used the
wrong lenght variable (local instead of field). This caused an
ArrayIndexOutOfBoudsException in System.arrayCopy().

slandelle pushed a commit that referenced this pull request Dec 19, 2013

Stephane Landelle
Merge pull request #1564 from froden/master
Fixed two issues in BytesInputStream.read

@slandelle slandelle merged commit bd6e2bf into gatling:master Dec 19, 2013

@slandelle

This comment has been minimized.

Copy link
Member

slandelle commented Dec 19, 2013

Oh man...

Thanks a lot!

@ghost ghost assigned slandelle Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment