Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate performance.md #131

Merged
merged 2 commits into from
Jan 27, 2020
Merged

docs: translate performance.md #131

merged 2 commits into from
Jan 27, 2020

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jan 26, 2020

概要

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

textlint で以下だけどうしても解決できなかったので、アドバイスをお願いします

  • 「に」の連続。「高速にするために」のようなところ。
  • 「。」で終わってない(絵文字のせい)

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 26, 2020
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exoego 良い翻訳と感じました!Lint で怒られている部分の修正を Suggest しました。ご確認お願いします。

Co-Authored-By: Jesse Katsumata <niconico.clarinet@gmail.com>
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!ありがとうございます!

@Naturalclar Naturalclar added status: awaiting author response A pull request that is awaiting author's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response status: awaiting author response A pull request that is awaiting author's response labels Jan 27, 2020
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます🚀

@uetchy uetchy merged commit 6374021 into gatsbyjs:master Jan 27, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 27, 2020
@exoego exoego deleted the performance branch January 29, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants