Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate docs/gatsby-image #141

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Translate docs/gatsby-image #141

merged 4 commits into from
Feb 5, 2020

Conversation

ryo4004
Copy link
Contributor

@ryo4004 ryo4004 commented Jan 29, 2020

概要

docs/gatsby-image を翻訳しました。
レビューよろしくお願いいたします。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

Ref: #1

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 29, 2020
@gatsbybot gatsbybot mentioned this pull request Jan 29, 2020
Open
Naturalclar
Naturalclar previously approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます！LGTM!

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 3, 2020
hirotaka
hirotaka suggested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！ちょっとだけ気になったところがあったのでご確認お願いいたします。

docs/docs/gatsby-image.md Outdated Show resolved Hide resolved
docs/docs/gatsby-image.md Outdated Show resolved Hide resolved
@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Feb 3, 2020
@ryo4004 @hirotaka
Update docs/docs/gatsby-image.md
97d8908 
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
@ryo4004 @hirotaka
Update docs/docs/gatsby-image.md
79ff0d3 
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
hirotaka
hirotaka reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たびたびすみませんが、1つだけコメントしたので、ご確認お願いいたします。

docs/docs/gatsby-image.md Outdated Show resolved Hide resolved
@ryo4004 @hirotaka
Update docs/docs/gatsby-image.md
cdc3a21 
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Feb 4, 2020
hirotaka
hirotaka approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！
LGTM 👍

@hirotaka hirotaka added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Feb 5, 2020
uetchy
uetchy approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uetchy uetchy merged commit 0fd7083 into gatsbyjs:master Feb 5, 2020
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirotaka hirotaka hirotaka approved these changes

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar left review comments

@smorimoto smorimoto Awaiting requested review from smorimoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryo4004 @hirotaka @uetchy @Naturalclar @smorimoto