-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate docs/deploying-to-aws-amplify #208
Merged
smorimoto
merged 4 commits into
gatsbyjs:master
from
harapeko:docs/deploying-to-aws-amplify
Feb 27, 2020
Merged
translate docs/deploying-to-aws-amplify #208
smorimoto
merged 4 commits into
gatsbyjs:master
from
harapeko:docs/deploying-to-aws-amplify
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harapeko
requested review from
hirotaka,
smorimoto,
Naturalclar and
uetchy
as code owners
February 25, 2020 18:29
smorimoto
added
the
status: awaiting review
A pull request that is currently awaiting a reviewer's response
label
Feb 26, 2020
hirotaka
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!いくつかSuggestionさせていただいたのでご確認お願いいたします。
hirotaka
added
status: awaiting author response
A pull request that is awaiting author's response
and removed
status: awaiting review
A pull request that is currently awaiting a reviewer's response
labels
Feb 26, 2020
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
Co-Authored-By: Hirotaka Mizutani <hirotaka@mizutani.to>
@hirotaka Suggestionを全て取り込みました! |
smorimoto
added
status: awaiting review
A pull request that is currently awaiting a reviewer's response
and removed
status: awaiting author response
A pull request that is awaiting author's response
labels
Feb 26, 2020
hirotaka
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!LGTM 👍
hirotaka
added
status: awaiting author response
A pull request that is awaiting author's response
status: awaiting more approval
A pull request that is awaiting reviewer #2 to be assigned
and removed
status: awaiting review
A pull request that is currently awaiting a reviewer's response
status: awaiting author response
A pull request that is awaiting author's response
labels
Feb 27, 2020
smorimoto
approved these changes
Feb 27, 2020
Thanks @harapeko for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
https://www.gatsbyjs.org/docs/deploying-to-aws-amplify/ の翻訳です
チェックリスト
textlint
を使って校正を行いました。Allow edits from maintainers
にチェックを入れました。補足
N/A
Ref: #1