Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate docs/creating-a-local-plugin #244

Merged
merged 8 commits into from
Apr 14, 2020
Merged

Translate docs/creating-a-local-plugin #244

merged 8 commits into from
Apr 14, 2020

Conversation

tkt989
Copy link
Contributor

@tkt989 tkt989 commented Mar 28, 2020

概要

docs/creating-a-local-pluginを翻訳しました。

チェック一覧

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@tkt989 tkt989 changed the title Docs/creating a local plugin Translate docs/creating-a-local-plugin Mar 28, 2020
@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Mar 28, 2020
Naturalclar
Naturalclar previously approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ありがとうございます！読みやすいと思いました:+1:

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Mar 29, 2020
uetchy
uetchy previously approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とても良い翻訳です！

@smorimoto
Copy link
Contributor

@tkt989 Could you resolve conflicts?

@smorimoto smorimoto added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Apr 3, 2020
@tkt989
Merge commit '4b3591553c9059a895799c71918ed426204a093c' into docs/cre…
c6f7a67 
…ating-a-local-plugin

# Conflicts:
#	docs/docs/creating-a-local-plugin.md
@tkt989
Copy link
Contributor Author

tkt989 commented Apr 6, 2020

resolved!

@tkt989 tkt989 added the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Apr 6, 2020
@tkt989 tkt989 removed the status: awaiting author response A pull request that is awaiting author's response label Apr 6, 2020
@smorimoto smorimoto merged commit 00bc864 into gatsbyjs:master Apr 14, 2020
@smorimoto
Copy link
Contributor

smorimoto commented Apr 14, 2020 •
edited
Loading

Thanks @tkt989! and we have been a little busy lately, so sorry for the late review.

@gatsbybot gatsbybot mentioned this pull request Apr 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uetchy uetchy uetchy approved these changes

@smorimoto smorimoto smorimoto approved these changes

@Naturalclar Naturalclar Naturalclar left review comments

@hirotaka hirotaka Awaiting requested review from hirotaka

Assignees
No one assigned
Labels
status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkt989 @smorimoto @uetchy @Naturalclar