Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate tutorial/part-one/index #27

Merged
merged 5 commits into from
Jan 19, 2020
Merged

docs: translate tutorial/part-one/index #27

merged 5 commits into from
Jan 19, 2020

Conversation

hirotaka
Copy link
Contributor

No description provided.

@hirotaka hirotaka marked this pull request as ready for review January 15, 2020 08:13
@gatsbybot gatsbybot mentioned this pull request Jan 15, 2020
Open
uetchy
uetchy suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-one/index.md Outdated Show resolved Hide resolved
@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 16, 2020
@hirotaka @Naturalclar @uetchy
Apply suggestions from code review
3e7335b 
Co-Authored-By: Jesse Katsumata <niconico.clarinet@gmail.com>
Co-Authored-By: Yasuaki Uechi <y@uechi.io>
uetchy
uetchy previously approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 16, 2020
Naturalclar
Naturalclar suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳は全体的に良いと思います！
半角と全角の間のスペースだけ追加したいです:bow:
quotation とかで囲まれてても Lint に反応させたい‥

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
@hirotaka @Naturalclar
Apply suggestions from code review
0770690 
Co-Authored-By: Jesse Katsumata <niconico.clarinet@gmail.com>
@hirotaka hirotaka mentioned this pull request Jan 17, 2020
Merged
4 tasks
@hirotaka
Copy link
Contributor Author

ありがとうございます！なんかお手間を取らせてしまって恐縮です。
textlintでできるよのがいいのですが、取り急ぎstyle-guideの方に追記してみました。
#68

@hirotaka hirotaka removed the status: awaiting author response A pull request that is awaiting author's response label Jan 17, 2020
@hirotaka hirotaka mentioned this pull request Jan 17, 2020
Closed
Naturalclar
Naturalclar approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます！

@Naturalclar Naturalclar merged commit 6157877 into master Jan 19, 2020
@Naturalclar Naturalclar deleted the tutorial/part-one branch January 19, 2020 02:56
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

@smorimoto smorimoto Awaiting requested review from smorimoto

Assignees
No one assigned
Labels
core pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirotaka @uetchy @Naturalclar