Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend BrowserApi for React Concurrent Mode #13675

Closed
pungggi opened this issue Apr 27, 2019 · 2 comments

Comments

@pungggi
Copy link

@pungggi pungggi commented Apr 27, 2019

Summary

Allow to tweak how the React App is rendered, but not only by wrapping the root element.

Basic example

Standard React:

ReactDOM.render(<App />, document.getElementById('root'));

Concurrent React:

ReactDOM.createRoot(document.getElementById('root')).render(<App />);

Motivation

Allow Gatsby to be used with the future of React Concurrent Mode.
https://www.gatsbyjs.org/docs/browser-apis/#wrapRootElement does not seem to do it, as it wraps the root element only.

@pungggi pungggi closed this Apr 27, 2019
@thiskevinwang thiskevinwang reopened this Oct 26, 2019
@thiskevinwang

This comment has been minimized.

@thiskevinwang

This comment has been minimized.

Copy link
Member

@thiskevinwang thiskevinwang commented Oct 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.