Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby Link check current href should with escape #18597

Closed
BerlinChan opened this issue Oct 14, 2019 · 0 comments

Comments

@BerlinChan
Copy link

@BerlinChan BerlinChan commented Oct 14, 2019

Description

Gatsby Link Component check current href NOT with escape

This bug has fixed in dependency @reach/router 1.2.1, but Gatsby Link still use version 1.1.1, like below:

"@reach/router": "^1.1.1",

Steps to reproduce

1- add <Link to={'/钢琴'} activeClassName={'activeLink'}>钢琴</Link>
2- navigat to: http://localhost:8000/钢琴/

Expected result

The "钢琴" a tag SHOULD have class activeLink

Actual result

The "钢琴" a tag NOT have class activeLink

Environment

npmPackages:

gatsby: ^2.15.36 => 2.15.36 
gatsby-link: ^2.2.20 => 2.2.20 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.