Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site showcase] change initial load from 9 sites to 12 #9393

Closed
amberleyromo opened this issue Oct 25, 2018 · 7 comments
Closed

[site showcase] change initial load from 9 sites to 12 #9393

amberleyromo opened this issue Oct 25, 2018 · 7 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby

Comments

@amberleyromo
Copy link
Contributor

Currently on first load of /showcase/ we load nine sites. This produces empty space at some resolutions. Changing the initial number loaded to 12 will be smoother at more resolutions.

@amberleyromo amberleyromo added Hacktoberfest good first issue Issue that doesn't require previous experience with Gatsby labels Oct 25, 2018
@amberleyromo amberleyromo changed the title [showcase] change initial load from 9 sites to 12 [site showcase] change initial load from 9 sites to 12 Oct 25, 2018
@abilash13
Copy link

I would like to work on this if that's okay?

@outofgamut
Copy link
Contributor

also had a PR in progress for this

@amberleyromo
Copy link
Contributor Author

Yep, marking as claimed. Thanks @abilash13!

@amberleyromo
Copy link
Contributor Author

amberleyromo commented Oct 25, 2018

Ah, ok @outofgamut.

@abilash13 could you check out the rest of the hacktoberfest issues? #8719 I'll be adding new Ecosystem ones periodically as well.

Apologies, I'll make it more clear that the issue should be claimed before a PR is opened. Y'all are too quick on the draw..!

@abilash13
Copy link

Ah no worries. Thanks!

@amberleyromo
Copy link
Contributor Author

Thank you @abilash13! 🙏🏼

@amberleyromo
Copy link
Contributor Author

Closed in #9395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby
Projects
None yet
Development

No branches or pull requests

3 participants