feat(gatsby): update react-hot-loader dependency to enable hooks #10259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per a find by @pieh, this was actually _not_ working, because yarn was using react-hot-loader@4.3.0 instead of the specified 4.5.1. With a resolutions field (which shouldn't be necessary once this is merged) this seems to be the fix
|
Successfully published:
|
theKashey
reviewed
Dec 4, 2018
| @@ -13,6 +13,12 @@ import pages from "./pages.json" | |||
| window.___emitter = emitter | |||
| setApiRunnerForLoader(apiRunner) | |||
|
|
|||
| // necessary for hot-reloading of react hooks | |||
| setConfig({ | |||
| ignoreSFC: true, | |||
There was a problem hiding this comment.
This option, without patches in React would disable RHL for any SFC at all.
Ie anything below any SFC would lose state. Probably this is not the goal.
Use pureSFC instead.
There was a problem hiding this comment.
Suggested change
| ignoreSFC: true, | |
| pureSFC: true, |
you mean?
There was a problem hiding this comment.
👍 👍 👍 👍
but look like pureSFC option is a bit broken in 4.5.1 - gaearon/react-hot-loader#1115
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…sbyjs#10259) * chore: upgrade to latest react-hot-loader to get some fixes * fix: get hot reloading working with 4.5.1 Per a find by @pieh, this was actually _not_ working, because yarn was using react-hot-loader@4.3.0 instead of the specified 4.5.1. With a resolutions field (which shouldn't be necessary once this is merged) this seems to be the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9881, Fixes #9489
This PR updates a dependency, and some minor changes in gatsby core, to enable hot reloading of React hooks code, as well as some IE 11 fixes.
As best as I can tell, the manual
setConfigis required to be called, but it's possible this may change in the future. See gaearon/react-hot-loader#1088 (comment) for more info.