Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve createPages of blog starter #10781

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@mottox2
Copy link
Member

commented Jan 2, 2019

Description

Remove extra promise in starters/blog/gatsby-node.js.

Related Issues

The same fixes is made for these pull requests.

#10357
#10777

`
).then(result => {
if (result.errors) {
console.log(result.errors)

This comment has been minimized.

Copy link
@DSchau

DSchau Jan 2, 2019

Contributor

We probably don't need to log here since the console will (already) output the thrown error, correct?

This comment has been minimized.

Copy link
@mottox2

mottox2 Jan 2, 2019

Author Member

Thanks. The log is unnecessary so I remove it.

mottox2 added some commits Jan 2, 2019

@DSchau

DSchau approved these changes Jan 2, 2019

Copy link
Contributor

left a comment

Looks great; thanks so much for the PR and for staying on top of the linter and fixing the issues :)

We're glad to have you as a contributor!

@DSchau DSchau merged commit 70bb589 into gatsbyjs:master Jan 2, 2019

13 of 14 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Danger All good
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsbygram Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node6 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
unit_tests_windows Build #20190102.55 succeeded
Details

gpetrioli added a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019

Improve createPages of blog starter (gatsbyjs#10781)
## Description
Remove extra promise in `starters/blog/gatsby-node.js`.

## Related Issues
The same fixes is made for these pull requests.

gatsbyjs#10357
gatsbyjs#10777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.