From 3ea19e3dd426d2a175d12f52a87eea3c70b60ed1 Mon Sep 17 00:00:00 2001 From: mottox2 Date: Thu, 3 Jan 2019 05:27:51 +0900 Subject: [PATCH 1/3] Improve createPages of blog starter --- starters/blog/gatsby-node.js | 78 +++++++++++++++++------------------- 1 file changed, 37 insertions(+), 41 deletions(-) diff --git a/starters/blog/gatsby-node.js b/starters/blog/gatsby-node.js index acd164192e90d..1c9ede684368b 100644 --- a/starters/blog/gatsby-node.js +++ b/starters/blog/gatsby-node.js @@ -4,55 +4,51 @@ const { createFilePath } = require(`gatsby-source-filesystem`) exports.createPages = ({ graphql, actions }) => { const { createPage } = actions - return new Promise((resolve, reject) => { - const blogPost = path.resolve(`./src/templates/blog-post.js`) - resolve( - graphql( - ` - { - allMarkdownRemark( - sort: { fields: [frontmatter___date], order: DESC } - limit: 1000 - ) { - edges { - node { - fields { - slug - } - frontmatter { - title - } - } + const blogPost = path.resolve(`./src/templates/blog-post.js`) + return graphql( + ` + { + allMarkdownRemark( + sort: { fields: [frontmatter___date], order: DESC } + limit: 1000 + ) { + edges { + node { + fields { + slug + } + frontmatter { + title } } } - ` - ).then(result => { - if (result.errors) { - console.log(result.errors) - reject(result.errors) } + } + ` + ).then(result => { + if (result.errors) { + console.log(result.errors) + throw result.errors + } - // Create blog posts pages. - const posts = result.data.allMarkdownRemark.edges + // Create blog posts pages. + const posts = result.data.allMarkdownRemark.edges - posts.forEach((post, index) => { - const previous = - index === posts.length - 1 ? null : posts[index + 1].node - const next = index === 0 ? null : posts[index - 1].node + posts.forEach((post, index) => { + const previous = + index === posts.length - 1 ? null : posts[index + 1].node + const next = index === 0 ? null : posts[index - 1].node - createPage({ - path: post.node.fields.slug, - component: blogPost, - context: { - slug: post.node.fields.slug, - previous, - next, - }, - }) - }) + createPage({ + path: post.node.fields.slug, + component: blogPost, + context: { + slug: post.node.fields.slug, + previous, + next, + }, }) - ) + }) }) } From d3f7f266deb8d3644f016e21e943edb41661e78d Mon Sep 17 00:00:00 2001 From: mottox2 Date: Thu, 3 Jan 2019 05:37:48 +0900 Subject: [PATCH 2/3] Remove unnecessary log --- starters/blog/gatsby-node.js | 1 - 1 file changed, 1 deletion(-) diff --git a/starters/blog/gatsby-node.js b/starters/blog/gatsby-node.js index 1c9ede684368b..3c13179cbb56f 100644 --- a/starters/blog/gatsby-node.js +++ b/starters/blog/gatsby-node.js @@ -27,7 +27,6 @@ exports.createPages = ({ graphql, actions }) => { ` ).then(result => { if (result.errors) { - console.log(result.errors) throw result.errors } From d98816286f3daff91dc630ae21cad85880df5e9f Mon Sep 17 00:00:00 2001 From: mottox2 Date: Thu, 3 Jan 2019 05:53:17 +0900 Subject: [PATCH 3/3] Format --- starters/blog/gatsby-node.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/starters/blog/gatsby-node.js b/starters/blog/gatsby-node.js index 3c13179cbb56f..df877b369440a 100644 --- a/starters/blog/gatsby-node.js +++ b/starters/blog/gatsby-node.js @@ -34,8 +34,7 @@ exports.createPages = ({ graphql, actions }) => { const posts = result.data.allMarkdownRemark.edges posts.forEach((post, index) => { - const previous = - index === posts.length - 1 ? null : posts[index + 1].node + const previous = index === posts.length - 1 ? null : posts[index + 1].node const next = index === 0 ? null : posts[index - 1].node createPage({