Skip to content

docs(gatsby): Removing pathname of wrapRootElement SSR (jsdocs) - #11844

Merged
wardpeet merged 1 commit into
gatsbyjs:masterfrom
NickCis:docs/fix-ssr-wrapPageElement
Feb 18, 2019
Merged

wardpeet merged 1 commit into
gatsbyjs:masterfrom
NickCis:docs/fix-ssr-wrapPageElement

Conversation

@NickCis

@NickCis NickCis commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

Description

This PR removes the property pathname in the docs to the wrapRootElement function as it isn't passed

Related Issues

@NickCis
NickCis requested a review from a team February 17, 2019 23:03

@wardpeet wardpeet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet @NickCis this is some forgotten cleanup.

@wardpeet wardpeet changed the title Docs: Removing pathname of wrapRootElement SSR docs(gatsby): Removing pathname of wrapRootElement SSR (jsdocs) Feb 18, 2019
@wardpeet
wardpeet merged commit 40faa74 into gatsbyjs:master Feb 18, 2019
@gatsbot

gatsbot Bot commented Feb 18, 2019

Copy link
Copy Markdown

Holy buckets, @NickCis — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@NickCis
NickCis deleted the docs/fix-ssr-wrapPageElement branch February 18, 2019 14:02
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants