Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gatsby): Removing `pathname` of `wrapRootElement` SSR (jsdocs) #11844

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@NickCis
Copy link
Contributor

NickCis commented Feb 17, 2019

Description

This PR removes the property pathname in the docs to the wrapRootElement function as it isn't passed

Related Issues

@NickCis NickCis requested a review from gatsbyjs/core as a code owner Feb 17, 2019

@wardpeet
Copy link
Contributor

wardpeet left a comment

Sweet @NickCis this is some forgotten cleanup.

@wardpeet wardpeet changed the title Docs: Removing `pathname` of `wrapRootElement` SSR docs(gatsby): Removing `pathname` of `wrapRootElement` SSR (jsdocs) Feb 18, 2019

@wardpeet wardpeet merged commit 40faa74 into gatsbyjs:master Feb 18, 2019

14 checks passed

Peril All green. Woo!
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsbygram Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node6 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
@gatsbot

This comment has been minimized.

Copy link

gatsbot bot commented Feb 18, 2019

Holy buckets, @NickCis — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@NickCis NickCis deleted the NickCis:docs/fix-ssr-wrapPageElement branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.