Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move diagram above card and change explanatory text #12236

Merged
merged 1 commit into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Mar 2, 2019

We couldn't fit the newly written text at the top pending a redesign of
the masthead but since we also wanted to move the diagram to the top, we
replaced its subheader with our new one.

screenshot 2019-03-01 18 16 36

Move diagram above card and change explanatory text
We couldn't fit the newly written text at the top pending a redesign of
the masthead but since we also wanted to move the diagram to the top, we
replaced its subheader with our new one.

@KyleAMathews KyleAMathews requested a review from gatsbyjs/website as a code owner Mar 2, 2019

@fk

fk approved these changes Mar 2, 2019

Copy link
Contributor

fk left a comment

🎉

@KyleAMathews

This comment has been minimized.

Copy link
Contributor Author

KyleAMathews commented Mar 2, 2019

The main downside to this is that the diagram looks a bit funny with the white space on either side on larger screens — but this seems good enough to get in for now so merging!

@KyleAMathews KyleAMathews merged commit a698ddd into master Mar 2, 2019

14 checks passed

Peril All green. Congrats.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsbygram Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node6 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details

@KyleAMathews KyleAMathews deleted the reorder-stuff branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.