Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add blog post about recently added graphiql-explorer #14393

Merged
merged 21 commits into from Jun 3, 2019

Conversation

Projects
None yet
6 participants
@pieh
Copy link
Contributor

commented May 29, 2019

feature was added in #14280

Preview:
localhost_8000_blog_2019-05-29-intergrating-graphiql-explorer_ (1)

@pieh pieh requested a review from gatsbyjs/docs as a code owner May 29, 2019

@DSchau
Copy link
Contributor

left a comment

Nice work! Left some comments 👇

pieh and others added some commits May 29, 2019

Apply suggestions from code review
Co-Authored-By: Dustin Schau <DSchau@users.noreply.github.com>
@KyleAMathews

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

I tweaked a sentence in the first paragraph — I couldn't figure out how to suggest changes for some reason so hope you like it :-D

@m-allanson
Copy link
Member

left a comment

Good stuff 🎉

@jlengstorf
Copy link
Member

left a comment

Looking great! A few suggestions for flow, adding credit more prominently, and grammar.

Apply suggestions from code review
Co-Authored-By: Jason Lengstorf <jason@lengstorf.com>
Co-Authored-By: Mike Allanson <michael.allanson@gmail.com>
@DSchau
Copy link
Contributor

left a comment

@pieh this ready for a merge? We'll probably want to change the date--how about tomorrow?

Show resolved Hide resolved docs/blog/2019-05-29-intergrating-graphiql-explorer/index.md Outdated
Show resolved Hide resolved docs/blog/2019-05-29-intergrating-graphiql-explorer/index.md Outdated

## Future work

There is opportunity for further improvements for Gatsby users. One that we will be tackling next is [support for using GraphQL fragments provided by Gatsby plugins](https://github.com/gatsbyjs/gatsby/issues/14371).

This comment has been minimized.

Copy link
@marcysutton

marcysutton May 31, 2019

Member
Suggested change
There is opportunity for further improvements for Gatsby users. One that we will be tackling next is [support for using GraphQL fragments provided by Gatsby plugins](https://github.com/gatsbyjs/gatsby/issues/14371).
There are opportunities for further improvements for Gatsby users. One that we will be tackling next is [support for using GraphQL fragments provided by Gatsby plugins](https://github.com/gatsbyjs/gatsby/issues/14371).

One other opportunity I'd love to mention is evaluating / improving accessibility of the GraphiQL interface. I haven't gotten a chance to review it really...I could perhaps file an issue to see if anyone wants to take it on?

This comment has been minimized.

Copy link
@pieh

pieh Jun 1, 2019

Author Contributor

I didn't notice mention about accessibility before.

I think this is great idea but not sure where the issue should live - we are "just" integrating graphiql and graphiql-explorer in our code ( https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-graphiql-explorer/src/app/app.js#L272-L316 ) so evaluating issue/ticket might be filed here, but actual changes (if any required) will need to be done mostly upstream:

This comment has been minimized.

Copy link
@pieh

pieh Jun 1, 2019

Author Contributor

I was doing quick keyboard navigation check and it doesn't seem great.

I also found couple of issues already reported in some graphiql related repositories:

Show resolved Hide resolved docs/blog/2019-05-29-intergrating-graphiql-explorer/index.md Outdated

pieh and others added some commits Jun 1, 2019

Apply suggestions from code review
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@@ -4,7 +4,7 @@ CUSTOM_COMMAND="${2:-yarn test}"
GATSBY_PATH="${CIRCLE_WORKING_DIRECTORY:-../../}"

# cypress docker does not support sudo and do not need it but the default node executor does
command -v sudo && sudo npm install -g gatsby-dev-cli || npm install -g gatsby-dev-cli &&
command -v sudo && sudo npm install -g gatsby-dev-cli@dev-verdaccio || npm install -g gatsby-dev-cli@dev-verdaccio &&

This comment has been minimized.

Copy link
@DSchau

DSchau Jun 3, 2019

Contributor

We probably don't want this, right?

This comment has been minimized.

Copy link
@pieh

pieh Jun 3, 2019

Author Contributor

oh yeah, let me revert that

@DSchau
Copy link
Contributor

left a comment

Looking good to me!

@pieh pieh force-pushed the pieh:blog/graphiql-explorer branch from 5fbf47d to 161e8c2 Jun 3, 2019

Update docs/blog/2019-06-03-intergrating-graphiql-explorer/index.md
Co-Authored-By: Dustin Schau <DSchau@users.noreply.github.com>
@DSchau

DSchau approved these changes Jun 3, 2019

Copy link
Contributor

left a comment

Re-re-re approving

@pieh pieh merged commit f4bbbd6 into gatsbyjs:master Jun 3, 2019

11 of 18 checks passed

ci/circleci: e2e_tests_development_runtime Your tests failed on CircleCI
Details
ci/circleci: e2e_tests_gatsby-image Your tests failed on CircleCI
Details
ci/circleci: e2e_tests_gatsbygram Your tests failed on CircleCI
Details
ci/circleci: e2e_tests_path-prefix Your tests failed on CircleCI
Details
ci/circleci: e2e_tests_production_runtime Your tests failed on CircleCI
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests failed on CircleCI
Details
ci/circleci: integration_tests_long_term_caching Your tests failed on CircleCI
Details
Danger All good
Details
Peril All green. Woo!
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node6 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
unit_tests_windows Build #20190603.55 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.