fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp #14881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
changed the title
|
I tested:
Both solved the |
wardpeet
force-pushed
the
fix/gatsby-cli-sharp-filesystem
branch
from
55c814f
to
c1ceea0
Compare
|
Tested using-wordpress & gatsbygram. Seems to work with gatsby-dev. Let me publish canary builds to make sure. |
|
I've tested it on the I tested it with NPM 😎 |
m-allanson
added a commit
that referenced
this pull request
Jun 19, 2019
* master: (41 commits) chore(release): Publish fix(gatsby): Normalize paths for run queries before caching (#14910) chore(release): Publish fix(gatsby-cli): add missing node-fetch dependency (#14908) feat(blog): Site Showcase Validator blogpost (#14855) chore(gatsby-remark-graphviz): add --ignore for test directory (#14906) fix(tutorials): rename "advanced" to "additional (#14847) fix(starters): update gatsby monorepo (#14886) chore(starters): Switch to useStaticQuery (#14857) chore(release): Publish Add status bar to bottom of screen during develop (#14874) chore(release): Publish fix(*): fix gatsby-cli dep in source-filesystem & plugin-sharp (#14881) docs(www): 25 Workflows - Embedding components in Markdown with MDX (#14543) docs(blog): add case study blog post for The Couch / Prima (#14871) docs(www): 25 Workflows - Adding CSS and/or Sass (#14779) fix(gatsby-transformer-react-docgen): always create description nodes (#14876) chore(release): Publish chore(gatsby): revert progressbar functionality (#14884) Revised "winning over engineering leaders" Docs page (#14830) ...
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
…yjs#14881) Bring back progressbar functionality in ink and npm fixes.
|
Hi, I'm using |
|
You have to pass it down but you're right about missing it in docs. Perhaps you can create an issue or a PR? |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…yjs#14881) Bring back progressbar functionality in ink and npm fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I forgot to add gatsby-cli as a dependency in gatsby-source-filesystem & gatsby-plugin-sharp 🤦♂.
Instead of adding it to dependencies we should accept it as a parameter based on the #4118 PR. This makes more sense as we probably get trouble with logging in the future.
I published some versions to test, please install the ones that are in your package.json
npm install gatsby-plugin-sharp@reporter-npmnpm install gatsby-source-contentful@@reporter-npmnpm install gatsby-source-drupal@reporter-npmnpm install gatsby-source-filesystem@reporter-npmnpm install gatsby-source-shopify@reporter-npmnpm install gatsby-source-wordpress@reporter-npmnpm install gatsby-transformer-screenshot@reporter-npmnpm install gatsby-transformer-sqip@reporter-npmRelated Issues
Fixes #14875