Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby-image): Add SEO advice to the readme #15056

Merged
merged 3 commits into from
Jun 24, 2019
Merged

docs(gatsby-image): Add SEO advice to the readme #15056

merged 3 commits into from
Jun 24, 2019

Conversation

fsgreco
Copy link
Contributor

@fsgreco fsgreco commented Jun 23, 2019

Description

I added a new advice under the "Other stuff to be aware" section.
During my report on github I have been invited (by @freiksenet ) to point out this issue on the documentation.

Related Issues

You can find more details and the discussion here: #13742

@anonimoconiglio
Add new advice on the "stuff to be aware" section
da930ef 
During my report on github I have been asked to point out this issue on the documentation. 
You can find more details and the discussion here: #13742
@fsgreco fsgreco requested a review from a team as a code owner June 23, 2019 15:54
wardpeet
wardpeet reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this to our docs. It's a good addition as not everyone knows about the problems this can cause.

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Jun 24, 2019
@wardpeet wardpeet changed the title Add new advice on the "stuff to be aware" section docs(gatsby-image): Add new advice on the "stuff to be aware" section Jun 24, 2019
@wardpeet wardpeet changed the title docs(gatsby-image): Add new advice on the "stuff to be aware" section docs(gatsby-image): Add SEO advice on the "stuff to be aware" section Jun 24, 2019
@wardpeet wardpeet changed the title docs(gatsby-image): Add SEO advice on the "stuff to be aware" section docs(gatsby-image): Add SEO advice to the readme Jun 24, 2019
anonimoconiglio and others added 2 commits June 24, 2019 11:01
@anonimoconiglio @wardpeet
Update packages/gatsby-image/README.md
4eda557 
Approve suggestion

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@wardpeet
fix lint
c6943a8
wardpeet
wardpeet approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@wardpeet wardpeet added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting author response Additional information has been requested from the author labels Jun 24, 2019
@gatsbybot gatsbybot merged commit 106185d into gatsbyjs:master Jun 24, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 24, 2019

Holy buckets, @anonimoconiglio — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@fsgreco fsgreco deleted the patch-1 branch June 24, 2019 21:49
johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
@anonimoconiglio @johno
docs(gatsby-image): Add SEO advice to the readme (gatsbyjs#15056)
b6c5585 
* Add new advice on the "stuff to be aware" section

During my report on github I have been asked to point out this issue on the documentation. 
You can find more details and the discussion here: gatsbyjs#13742

* Update packages/gatsby-image/README.md

Approve suggestion

Co-Authored-By: Ward Peeters <ward@coding-tech.com>

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsgreco @wardpeet @gatsbybot @anonimoconiglio