Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): Use babel plugin to remove export keyword #15452

Merged
merged 1 commit into from Jul 9, 2019

Conversation

Projects
None yet
5 participants
@johno
Copy link
Member

commented Jul 5, 2019

For very large MDX documents babel will deopt styling. This
results in variations in whitespace that can't be handled
by the original regex for stripping the export keyword.

This replaces that functionality with a plugin.

Related

@johno johno requested a review from ChristopherBiscardi Jul 5, 2019

@johno johno requested a review from gatsbyjs/core as a code owner Jul 5, 2019

@ChristopherBiscardi
Copy link
Member

left a comment

yess, so happy to see that regex go away.

@rwieruch

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Wow, thanks for your work on this @johno Super surprised and excited to see people like you behind a library doing everything to make it perfect and to help people out. ❤️ Looking forward to this merge 👍

fix(gatsby-plugin-mdx): Use babel plugin to remove export keyword
For very large MDX documents babel will deopt styling. This
results in variations in whitespace that can't be handled
by the original regex for stripping the export keyword.

This replaces that functionality with a plugin.

- ChristopherBiscardi/gatsby-mdx#411
- https://github.com/mdx-js/mdx#618

@johno johno force-pushed the johno:export-removal branch from 2ec5a02 to 3923be4 Jul 9, 2019

@sidharthachatterjee
Copy link
Member

left a comment

Looking good @johno 🥇

@gatsbybot gatsbybot merged commit d3582b0 into gatsbyjs:master Jul 9, 2019

18 checks passed

Danger All good
Details
Peril All green. Nice work.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsbygram Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: theme_starters_validate Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
unit_tests_windows Build #20190709.39 succeeded
Details

@johno johno deleted the johno:export-removal branch Jul 9, 2019

rayriffy added a commit to rayriffy/gatsby that referenced this pull request Jul 14, 2019

fix(gatsby-plugin-mdx): Use babel plugin to remove export keyword (ga…
…tsbyjs#15452)

For very large MDX documents babel will deopt styling. This
results in variations in whitespace that can't be handled
by the original regex for stripping the export keyword.

This replaces that functionality with a plugin.

- ChristopherBiscardi/gatsby-mdx#411
- https://github.com/mdx-js/mdx#618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.