Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-shopify): add metafields to product nodes #16312

Merged

Conversation

@kellyvaughn
Copy link
Contributor

commented Aug 1, 2019

Description

Shopify introduced access to metafields via the Storefront API back in May. This adds the metafield endpoint to products via gatsby-source-shopify.

Related Issues

N/A

@kellyvaughn kellyvaughn requested review from gatsbyjs/core as code owners Aug 1, 2019

@amberleyromo
Copy link
Member

left a comment

Awesome, thanks for adding this!

@DSchau

DSchau approved these changes Aug 1, 2019

Copy link
Contributor

left a comment

Thanks for this!

I'll get this published as a minor release, since it's technically introducing a new feature.

🎉

@@ -129,6 +138,9 @@ export const ProductNode = imageArgs =>
return node
})

export const ProductMetafieldNode = _imageArgs =>

This comment has been minimized.

Copy link
@DSchau

DSchau Aug 1, 2019

Contributor

Not really new here -- but I wonder why this pattern is used through all of these node types?

Oh well!

This comment has been minimized.

Copy link
@kellyvaughn

kellyvaughn Aug 1, 2019

Author Contributor

That's a really good question - I didn't want to reinvent anything, so I just followed the same pattern as before. I don't totally understand it to be entirely honest.

This comment has been minimized.

Copy link
@DSchau

DSchau Aug 1, 2019

Contributor

🤷‍♂ Your guess is as good as mine. Not hurting anything -- we'll clean it up later!

@DSchau DSchau changed the title Topics/upgrade gatsby source shopify to include product metafields feat(gatsby-source-shopify): add metafields to product nodes Aug 1, 2019

@DSchau DSchau merged commit 271bad2 into gatsbyjs:master Aug 1, 2019

18 checks passed

Danger All good
Details
Peril All green. Good on 'ya.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
unit_tests_windows Build #20190801.139 succeeded
Details
@gatsbot

This comment has been minimized.

Copy link

commented Aug 1, 2019

Holy buckets, @kellyvaughn — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@DSchau

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Published as gatsby-source-shopify@2.2.0.

Enjoy the swag 🎉

johno added a commit to johno/gatsby that referenced this pull request Aug 2, 2019

feat(gatsby-source-shopify): add metafields to product nodes (gatsbyj…
…s#16312)

* add metafields to product query

* update readme note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.