Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update typescript example #17300

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@Naturalclar
Copy link
Member

Naturalclar commented Sep 1, 2019

Description

Updated packages and types in using-typescript example as it was a bit outdated.

@Naturalclar Naturalclar requested a review from gatsbyjs/core as a code owner Sep 1, 2019
@Naturalclar Naturalclar changed the title chore(examples): update react types chore(examples): update typescript example Sep 1, 2019
Copy link
Member

wardpeet left a comment

This looks good! thank you for updating our example.

@wardpeet wardpeet merged commit fa9f5ca into gatsbyjs:master Sep 2, 2019
15 of 16 checks passed
15 of 16 checks passed
ci/circleci: starters_validate Your tests failed on CircleCI
Details
Danger All good
Details
Peril All green. Nice work.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsbygram Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node6 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
unit_tests_windows Build #20190901.59 succeeded
Details
@gatsbot

This comment has been minimized.

Copy link

gatsbot bot commented Sep 2, 2019

Holy buckets, @Naturalclar — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@Naturalclar Naturalclar deleted the Naturalclar:example/Typescript branch Sep 2, 2019
waltercruz added a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.