Update hashed-chunk-ids-plugin.js #1753
Conversation
This skips the hash function if the chunk.id is null and chunk.name is undefined. Assume that if the id is null and the name is undefined, then there is something wrong with that module and do not hold up the entire build process.
|
Deploy preview ready! Built with commit c376f9d |
|
Deploy preview ready! Built with commit c376f9d |
|
Ok... I guess this is better than what we had before? What I don't know is how webpack will respond to us returning the same key for multiple chunks. Does it combine them internally or something or not know how to reference them? Perhaps creating a random value would make more sense? |
|
Though I dunno, if the chunk.id and chunk.name are already null then clearly webpack handles it somehow or another… |
|
I think there was a check that webpack added in v2 that circumvented this error. (webpack/webpack#4072). Obviously upgrading to webpack 2 is a big ticket item and is already a different PR. Essentially we are performing our own check. If there is an issue with the module then we should see a different error somewhere else. Right now the hash function fails, and doesn't show which module is failing it just brings the build process to a halt. I know this may not 'fix' the issue but I think it is a little better. It certainly fits my needs and use case. |
|
Cool, let's give this a go then. Probably won't make anything worse 😈 |
This skips the hash function if the chunk.id is null and chunk.name is undefined. Assume that if the id is null and the name is undefined, then there is something wrong with that module and do not hold up the entire build process.
This is in reference to #1659