Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(schema): speed up and lower memory usage of type inference #18008

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@me4502
Copy link
Member

me4502 commented Sep 30, 2019

Description

Type inference was completely hammering the garbage collector before with a large schema, and started to cause issues and node crashes when I tried lowering the memory. This takes it from 20s to 5s, and prevents the massive GC churn.

@me4502 me4502 requested a review from gatsbyjs/core as a code owner Sep 30, 2019
@pieh pieh self-assigned this Oct 8, 2019
@pieh
pieh approved these changes Oct 15, 2019
Copy link
Contributor

pieh left a comment

LGTM and I did local verification, let's get this in!

@pieh pieh changed the title chore(schema): speed up and lower memory usage of type inference perf(schema): speed up and lower memory usage of type inference Oct 15, 2019
@pieh pieh merged commit e87ac50 into gatsbyjs:master Oct 15, 2019
20 checks passed
20 checks passed
Danger All good
Details
Peril All green. Congrats.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 67 tests passed in 00:28
Details
unit_tests_windows Build #20190930.19 succeeded
Details
@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Oct 15, 2019

Published in gatsby@2.16.3

@me4502 me4502 deleted the clipchamp:chore/faster-inference branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.