Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Fix matchpath ordering #18478

Merged
merged 6 commits into from Oct 24, 2019
Merged

fix(gatsby): Fix matchpath ordering #18478

merged 6 commits into from Oct 24, 2019

Conversation

@sever1an
Copy link
Contributor

sever1an commented Oct 10, 2019

Description

Path matching should always chose the most specific match, such that paths like /app/static-page should be chosen over /app/*. There is presently a regression where /app/* is chosen over /app/<index.js>, which is actually just /app/.

In this commit ( 6c64948#diff-ac5196f8e8e35e4455b30b9164e3c45b ), the way static pages are handled within match paths was changed, such that any static page within the domain of a glob (*) match path is given its own entry in .cache/match-paths.json. To allow for static pages to take precedence the over glob paths, the order of this file is important... more specific routes must be tested before less specific ones.

The order of entries in .cache/match-paths.json is ultimately determined by packages/gatsby/src/bootstrap/requires-writer.js.

Paths are assigned a score based on how specific they are by basically counting slashes, but the trailing slash is removed first. For an index page the trailing slash is significant, as it implies /index. Globs like /* and /app/* initially score one point higher than / and /app/ then are equal after a bonus for no *. Yes, this might even present undefined behavior. Removing a trailing * along with the trailing / puts glob paths at the equivalent level of an index page with removed slash instead of a child page during the initial scoring, then the index gains a point for not having a *. I believe that this always places glob paths after static pages that they might shadow. It should also maintain the relative order of specificity among different glob paths. For example /app/stuff/* should be chosen over /app/* and /*.

Related Issues

I believe that this a regression which will break existing apps when gatsby is updated. The author of 17980 discovered it with CI testing.

Fixes #17980

sever1an added 2 commits Oct 10, 2019
…es glob paths at an equal level to index paths. Test for glob path prescedence now uses `toEqual` for deep object comparison.
@sever1an sever1an requested a review from gatsbyjs/core as a code owner Oct 10, 2019
@sever1an sever1an changed the title Topics/fix matchpath globs replace index Fix matchpath globs supersede index.js pages. Oct 11, 2019
@wardpeet

This comment has been minimized.

Copy link
Member

wardpeet commented Oct 11, 2019

Hey, codewise this looks good. I couldn't reproduce the bug. Do you have a reproduction?

@sever1an

This comment has been minimized.

Copy link
Contributor Author

sever1an commented Oct 11, 2019

I have created two reproductions. Since the scores for * paths end up equaling index paths, the behavior seems to depend on node creation order. For pages from the src directory they seem to be added alphabetically by glob. In this case the silly name zapp-glob is required to show the error.

This one shows an error on the path /app/ https://github.com/sever1an/match-path-error/tree/folder-error

This one shows an error on / and /app/
https://github.com/sever1an/match-path-error/tree/root-error

[
    {
        "path": "/404.html",
        "matchPath": "/404.html"
    },
    {
        "path": "/zapp-glob/",
        "matchPath": "/app/*"
    },
    {
        "path": "/app/",
        "matchPath": "/app/"
    },
    {
        "path": "/404/",
        "matchPath": "/404/"
    },
    {
        "path": "/root-glob/",
        "matchPath": "/*"
    },
    {
        "path": "/",
        "matchPath": "/"
    }
]
@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 14, 2019

Is there any movement?

@sidharthachatterjee sidharthachatterjee self-assigned this Oct 16, 2019
@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 20, 2019

Can you please merge this PR and publish?

@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 21, 2019

I'm sorry to buzz, but 5 of my projects having bugs, which will be fixed with this commit

@sever1an

This comment has been minimized.

Copy link
Contributor Author

sever1an commented Oct 21, 2019

@JustFly1984 Have you pulled and tested this branch with your projects?

@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 22, 2019

@sever1an how can I test this branch in my project?

@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 24, 2019

is there any movement?

Copy link
Member

wardpeet left a comment

Hey @sever1an, Thanks for opening this PR! Sorry for taking so long, your changes look great! 👍

@wardpeet wardpeet changed the title Fix matchpath globs supersede index.js pages. fix(gatsby): Fix matchpath ordering Oct 24, 2019
…ath-globs-replace-index
…ath-globs-replace-index
@gatsbybot gatsbybot merged commit b8aa333 into gatsbyjs:master Oct 24, 2019
19 checks passed
19 checks passed
Danger All good
Details
Peril All green. Well done.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
@gatsbot

This comment has been minimized.

Copy link

gatsbot bot commented Oct 24, 2019

Holy buckets, @sever1an — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Oct 25, 2019

Published gatsby@2.17.3

@JustFly1984

This comment has been minimized.

Copy link

JustFly1984 commented Oct 27, 2019

Thank you, it solved my issues with 404

shobhitchittora added a commit to shobhitchittora/gatsby that referenced this pull request Oct 31, 2019
* chore(docs): add lines to express need for plugin to prevent F… (#18595)

* fix(gatsby-theme-blog): remove extension on bio-content import (#18555)



Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>

* chore(showcase): Add haxzie.com (#18717)

* Showcase: Add haxzie.com to sites.yml

Showcasing my personal blog which is built with Gatsby :sparkles:

* Fix typo in url

* chore(docs): Update docs to adhere to style guide (#18656)

* Changed we/our to you/your

* Change you/your to we/our

* Change we/our to you/your

* Change sentences with we to be more direct

* Format documents

* Update docs/docs/production-app.md

Changing it to "you" doesn't make sense here.

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/production-app.md

Using "Gatsby" makes more sense than using "you" here

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/production-app.md

Using "Gatsby" makes more sense than using "you" here

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/production-app.md

Using "Gatsby" makes more sense than using "you" here

Co-Authored-By: Lennart <lekoarts@gmail.com>

* chore(docs): Replaced occurences of 'we' and 'our' with 'you'… (#18696)



Co-authored-by: Dallin Noel Skinner <dallin.skinner@podium.com>

* chore(docs): Title Casing Update (#18706)

* chore(showcase): Add plenty of fish, bitcoin.com, frame.io and… (#18667)



Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Used “you” and "you're" as the pronoun (#18707)

* chore(docs): Title Casing update (#18708)

* chore(docs): Used “you'll” instead of "we'll" (#18709)

* chore(docs): Updated the pronouns used (#18710)

* chore(docs): Minor grammar correction (#18712)

* chore(showcase): Add PearlyPlan.com to site showcase (#18643)

* Add PearlyPlan.com to site showcase

* sites.yml

* fix categories


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Updated pronouns usage (#18711)

* chore(docs): Updated pronouns usage

* chore(docs): updated wording of example

* chore(docs): Replace 'our' with 'your' in adding-markdown-page… (#18700)

* chore(docs): Update index.md to adhere to Gatsby style guide (#18724)

Updated case of heading for tutorial: zero link

* chore(docs): Add freecodecamp community to other resources sec… (#18725)

* fix(gatsby-plugin-netlify): cast `status` to string (#18726)

* fix(gatsby-plugin-netlify): cast `status` to string

* Update create-redirects.js

* chore(showcase): wedoplugins.com (#18693)

* wedoplugins.com website added to sites.yml

* newline added

* chore(gastby-plugin-sharp): Use createContentDigest helper (#18139)

* chore(gastby-plugin-sharp): Use createContentDigest helper

Updates the plugin to use the help instead of manually handling the
crypto work. Functions were added to the pass the helper down into the
process-file module, similar to how setBoundActionCreators was working
but with an extra level.

Relates to #8805

* chore(gastby-plugin-sharp): Use createContentDigest from core-utils

* chore(release): Publish

 - gatsby-plugin-netlify@2.1.22
 - gatsby-plugin-sharp@2.2.32
 - gatsby-source-contentful@2.1.50
 - gatsby-transformer-sqip@2.1.36

* fix(creators): update AJonP Logo to new Branding (#18735)

* Adding AJonP as creator and site

* fixing aj's categories

* updated icon

* add anchors blog post

* Revert "add anchors blog post"

This reverts commit 967c41cf4ce47031703cc7b0d2a0b641d650deaa.

* chore(showcase): add Dashbouquet (#18505)

* add site to showcase

* Update docs/sites.yml

Co-Authored-By: Ward Peeters <ward@coding-tech.com>

* Update docs/sites.yml

Co-Authored-By: Ward Peeters <ward@coding-tech.com>

* chore(showcase): Add North X South (#18701)

* chore(showcase): Add yangmuzi.com (#18730)

* Added a GatsBy blog side project

* Added a Gatsby blog side project to the sites.yml

* starters(readme): fix broken link (#18739)

* fix flow version in .flowconfig (#18734)

* grouping together minor updates in renovate.json rule (#18644)

* grouping together minor updates in renovate.json rule

* adding rule for patch updates

* docs: Added rus and ukr articles to awesome-gatsby-resources (#18722)

* chore(docs): Clear up wording in Winning Over Stakeholders (#18746)

* chore(docs): three new resources to the Gatsby tutorials section (#18729)

* Update awesome-gatsby-resources.md

* remove duplicates

* chore(docs): p-files Part2 - adjust headlines according to style guide + adjust some texts (#18716)

* adjust headlines & titles to fit style guide + adjust some texts

* revert non-descriptive headline

* revert change

* chore(blog): Grammar fix (#18747)

* Update according to Style Guide

Minor fixes on the following
*Title casing*
*Grammar*

* revert title change

* refactor(gatsby-cli): replace react-redux with React context (#18752)

* chore(docs):title case and punctuation fixes (#18750)

* chore(release): Publish

 - gatsby-cli@2.8.2
 - gatsby@2.16.4

* chore(docs): Grammar fixes (#18751)

* Grammar fixes for docs-contributions.md

* Update community-contributions.md

Minor grammar change (redundancy)

* chore(blog): Fix broken link (#18737)

* Fix broken link

Fix broken link to **gatsby-plugin-segment-js** docs

* Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-delaying-third-party-scripts/index.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* added Pagepro as creator (#18756)



Co-authored-by: Chris (Krzysztof) Lojniewski <kontakt@pagepro.pl>

* chore(showcase): Remove two categories from entries (#18757)

* chore(docs): i-files - adjust headlines according to style gui… (#18695)

* i-files: adjust headlines according to style guide + adjust some texts

* trigger circleCi

* revert some text changes

* chore(showcase): Add robinwieruch.de (#18761)

* chore(docs): Update README.md (#18733)

* Update README.md

Improved documentation

* docs(themes): Update README.md

Followed Prettier code style

* Update themes/README.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update README.md

update the doc with appropriate link

* Update README.md

* Update README.md

* Update themes/README.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update README.md

* docs(www): Use yarn consistently in the README.md file (#18755)

* docs(www): Use yarn consistently in the README.md file

* Update www/README.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* chore(sites): remove sites that are no longer gatsby sites (#18765)

* docs: preprocessing external images page (#17497)

* Initial work on preprocessing external images page

* Applying Lennart's suggestions from code review

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Finishing up initial draft of post & adding images

* Apply suggestions from Muescha code review

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Removing 2nd "That said" in intro paragraphs

* Apply suggestions from code review

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/preprocessing-external-images.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/preprocessing-external-images.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update preprocessing-external-images.md

* Updating with changes suggested by Muescha and Lennart

* adding punctuation

* Apply suggestions from code review

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/preprocessing-external-images.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Adding alt text for featured image through guide

* Update docs/docs/preprocessing-external-images.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Adding paragraph for mentioning Schema Customization API before code snippet

As well, renaming all instances of "blogpost" to "blog post" so the post is consistent.

* Add note that new node is not part of frontmatter

* Apply suggestions from code review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* revert svg changes

* chore: remove svg changes

* docs: removing stub for reach router doc (#18784)

* Adding docs to reach router

* Update docs/docs/reach-router-and-gatsby.md

Co-Authored-By: Mae Capozzi <maecapozzi@gmail.com>

* Update docs/docs/reach-router-and-gatsby.md

Co-Authored-By: Mae Capozzi <maecapozzi@gmail.com>

* Update docs/docs/reach-router-and-gatsby.md

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* Tweaks to wording based on suggestions

* chore(themes): move themes into starters and packages (#18794)

* Move theme starters into starters

* Move themes into packages

* Remove themes directory

* Cleaned up the renovate config

* Cleaned up the lerna config

* Cleaned up the CI config

* Exclude theme starters from markdown-magic

* Cleaned up themes package.json

* fix dependencies in yarn.lock

* add missing peer dependency

* fix(gatsby-plugin-feed): Remove wrong overriding in plugin-feed (#18793)

* fix(gatsby-cli): re-add reporter._setStage as no-op function (#18797)

* fix(gatsby-cli): re-add reporter._setStage as no-op function

* fix version range in comment

* chore(release): Publish

 - gatsby-cli@2.8.3
 - gatsby-plugin-feed@2.3.19
 - gatsby-theme-blog-core@1.0.3
 - gatsby-theme-blog@1.1.3
 - gatsby-theme-notes@1.0.4
 - gatsby@2.16.5

* fix(www): fix issue with showcase titles (#18799)

* chore(docs):Replaced the word 'easy' to use more inclusive lan… (#18813)

* moving content around

* Topics/free headless cms (#18694)

* Add blog post - free headless CMS

* add updates to free CMS blog posts

* removed "gatsby-plugin-sharp duotone fixed 2"

* Fix linting

* chore(showcase): add visitrestore.com (#18814)

* chore(showcase): add visitrestore.com

<!--
  Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

<!--
  Is this a blog post? Check out the docs at https://www.gatsbyjs.org/contributing/blog-and-website-contributions/, and please mention if the blog post is pre-approved
  by someone from Gatsby.
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes #1234

  Link to an issue that is partially addressed by this PR (if there are any)
  e.g. Addresses #1234

  Link to related issues (if there are any)
  e.g. Related to #1234
-->

* chore: format

* fix(showcase): URL change from evergov to papergov in showcase (#18773)

* chore(docs): Remove reach-router stub asterisk from sidebar (#18800)

* chore(showcase): Add regex.guide (#18789)

* feat(gatsby): Move webpackCompilationHash into app-data.json (#16686)

* chore(release): Publish

 - gatsby-theme-blog-core@1.0.4
 - gatsby-theme-blog@1.1.4
 - gatsby-theme-notes@1.0.5
 - gatsby@2.17.0

* refactor(gatsby-transformer-sharp): Use explicit graphql type definition vs inferring (#18871)

* refactor(gatsby-transformer-sharp): Use explicit graphql type definition vs inferring (#17531)

* Change minimal version of gatsby dependency to the one having schema customization API

* feat(showcase): add Rockwong Blog (#18772)

* Rockwong Blog added to showcase

Added Rockwong which is a techncal blog containing content realted to various web technologies.

* Update docs/sites.yml

Updated main url of the blog built by Gatsby

Co-Authored-By: Michal Piechowiak <misiek.piechowiak@gmail.com>

* chore(starters): add iceberg-gatsby-multilang (#18807)

* chore(starters): add iceberg-gatsby-multilang

* chore(starters): add iceberg-gatsby-multilang

* chore(starters): add iceberg-gatsby-multilang

* fixing syntaxe

* feat(showcase): add diff001a's blog (#18770)

* diff001a's blog added

diff001a's blog which contains blogs realted to programming is added to Showcase

* Update sites.yml

* chore(release): Publish

 - gatsby-theme-blog-core@1.0.5
 - gatsby-theme-blog@1.1.5
 - gatsby-transformer-sharp@2.3.0

* fix(www): mobile nav for iPhone X (#18845)

* fix: fix bottom navbar on Iphone X

* fix: remove unused property

* fix: (gatsby-plugin-mdx)update readme (#18885)

* Update working-with-images-in-markdown.md (#18825)

* Update gatsby-in-the-enterprise.md (#18826)

* Update working-with-gifs.md (#18829)

Fix grammar

* Gatsby Style Guide for Title (#18824)

Keeping consistent with other Gatsby title's that are using "with" as lowercase on their titles.

* Updated with of title to lowercase (#18859)

Updated with of title to lowercase to make it consistent with other titles.

* chore(docs): Update pronouns on "Behind the scenes" (#18428)

* updated doc to use you and your

* updated doc to use you and your

* updated last q doc to use you and your

* Update docs/docs/query-behind-the-scenes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-behind-the-scenes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-execution.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/query-extraction.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Issue for image heavy site (#18421)

* chore(docs): Fix MD syntax in MDX docs (#18766)

* Fix and add syntax

Fix rendering syntac inside `code` for `table` and `tr` and add examples of `code` and `pre`.

* chore: format


Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>

* chore(starters): add MDX to gatsby-starter-morning-dew (#18832)

* chore(starters): gatsby-starter-grayscale-promo (#18815)

* gatsby-starter-grayscale-promo

* tags fixed

* move to bottom


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Fix broken link (docs/audit with Lighthouse) (#18837)

* Updated "with" in lowercase in title. (#18861)

Updated "with" in lowercase in title to make it more consistent with other titles.

* chore(showcase): Add Utah Pumpkins (#18842)



Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Replace 'our' with 'your' in bulma and blog docs (#18876)

* chore(showcase): Add mysteps.netlify.com (#18846)

*  Added mysteps.netlify.com to sites.yml. Thanks!

* chore: format


Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>

* chore(starters): gatsby-tailwind-emotion-starter (#18888)

* Add gatsby-tailwind-emotion-starter to starters.yml

* Fix backticks


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Add Keycodes to showcase (#18868)



Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Update query-extraction - fixed some broken links (#18878)

* Update query-extraction.md

Found some broken links that were easy enough to fix.

* Update query-extraction.md


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Add two sites to sites.yml and add author fie… (#18869)

* Adds two sites to sites.yml and adds author field

I already had one site on here and updated who authored it.

* remove community category


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Removing Mixkit (#18880)

The Site Showcase found it was no longer a Gatsby site (now using NextJS), so I'm removing it from the showcase

* chore(showcase): Add Global Adviser Alpha (#18870)



Co-authored-by: Keeko Montojo <keeko@hellohandsome.com.au>
Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Add Roger Ramos Journal (#18843)



Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): Update with in lowercase in title (#18860)

Update "with" lowercase in title to make it consistent with other titles.

* chore(docs): clarify the message about links (#18899)

* [contributing] I18n onboarding doc (#18424)

* add translation guide

* add links to docs on community page

* add more info about team conventions

* PR feedback

* PR feedback, updates from reviews

* more feedback and linting!

* last bits of PR feedback

* update heading levels for maintainer section

* chore(docs): make ordered list more consistent (#18900)

* make ordered list more consistent

* chore: format


Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>

* adding bululueventos.cl (#18901)



Co-authored-by: Lennart <lekoarts@gmail.com>

* fix(blog): Fixing the link (#18905)

* fix(gatsby-source-wordpress): add undefined check to avoid mapPostsToTagsCategories error (#18895)

* fix(gatsby-cli): properly update chalk color level (#18533)

* chore(release): Publish

 - gatsby-cli@2.8.4
 - gatsby-plugin-mdx@1.0.53
 - gatsby-source-wordpress@3.1.44
 - gatsby-theme-blog-core@1.0.6
 - gatsby-theme-blog@1.1.6
 - gatsby-theme-notes@1.0.6
 - gatsby@2.17.1

* Convert docs introduction to mdx (#18014)

* docs: convert docs introduction to mdx

* docs: remove table of contents

* feat(gatsby-source-drupal): secrets and delete functionality (#18345)

* added functionality to delete nodes and enforce secret for more secure preview instances

* added documentation for secret in config

* updated handleWebhookData and destructured varaibled from request

* using deleteNode from actions

* deleteNode working and reporting deleted node to user

* updated documentation on using secrets to be consistent with the rest of the readme.

* change destructuring due to failing tests

* fix undefined res

* added return for lint

* chore(release): Publish

 - gatsby-source-drupal@3.3.0

* fix(gatsby): ensure `@childOf` adds convenience fields before root field arguments (#18935)

* Added failing test for the convenience root field

* Ensure convenience fields are added before root field arguments

* feat(gatsby): Ensure status is set to Failed for thrown errors or panicOnBuild in plugins (#18887)

* cause gatsby develop to error for errored createPages in plugins

* add ActivityErrored action to list of internal actions

* ensure activity.end() is called after activity.panicOnBuild

* override reporter panicOnBuild in plugins

* flag progress activity when panicOnBuild is called instead of ending immediately

* fail `createPagesStatefully` activity on errors

* fail activity on errors in `onCreatePage`

* add test to assert that calling reporter.panicOnBuild will fail the activity

* use localReporter variable to prevent code duplication

* fix: fix overriding default options of `gatsby-plugin-page-creator` on Windows (#18828)

* chore(release): Publish

 - gatsby-cli@2.8.5
 - gatsby-theme-blog-core@1.0.7
 - gatsby-theme-blog@1.1.7
 - gatsby-theme-notes@1.0.7
 - gatsby@2.17.2

* chore(docs): update to match the starter (#18947)

* Updates author information for Ilesh (#18948)

* Remove Azure Pipeline runs since Windows tests run on CircleCI

* Add gatsby-plugin-colorblind-filters to Hacktoberfest blog post (#18938)

* docs: fix incorrect filename (#18955)

`import "./commands"` is actually found in `cypress/support/index.js` . I think this either changed recently by Cypress or was an error. 

This PR proposes changing filename from `cypress/support/commands.js` to `cypress/support/index.js` where `import "./commands"` is now found.

* fix(www): use UTC timezone to display dates on events page (#18954)

* Add UTC timezone 

The source of the dates, Airtable was changed to send dates using UTC timezone. This code change will  correct dates that are currently being displayed as 1 day off.

* chore: format

* fix(www): Showcase site detail modal responsiveness (#18956)

* chore(starters): gatsby-starter-typescript-contentful (#18972)

* chore: change workflow schedule (#18979)

* chore: change workflow schedule

Switch from daily to weekly for this action

* Switch to Tuesday

* update `gatsby-starter-orga` info (#18957)

* fix(renovate): disable yarn upgrades (#18981)

* fix(renovate): disable yarn upgrades

* fix(renovate): disable upgrading all engines

* chore(docs): Edited pronouns to use second person pronouns (#18962)

* edited pronouns to use second person pronouns

* edited passive voice to use active voice

* removed let's

* more pronoun changes

* Docs: Recipe for Contentful data source (#17318)

* Added recipe for sourcing from contentful

* Editing

* Moved Conentful recipe into recipe.md

* Prettier formatting

* Apply suggestions from code review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Removed issue note

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* More base-relative URLs.

* Linting

* Added example repo

* Added readme to sample

* Stronger language on environment variables

* Semantic example

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Removed unneeded files from example, news in index

* Formatting for step 4

* Define example field types

* Tightened up a sentence

* Changed to using seeded blog space

* Use page context

* Unused graphql variable

* Edited readme

* Added env vars note

* Changed recipe to use contentful blog seed

* Removed duplicate content

* Applied suggestions from review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Extra space

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Applied code review suggestions

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update working-with-images-in-markdown.md (#17806)

* Update working-with-images-in-markdown.md

I was having lots of troubles getting this to recognize the path I used for my image in my markdown file as a File. It turns out it's because I wasn't loading my images directory in `gatsby-source-filesystem`. This should help prevent others from having issues with this.

* Update working-with-images-in-markdown.md

* Update docs/docs/working-with-images-in-markdown.md

* add separate sections for sourcing images/Markdown

* restoring original inline example w/ original img

* docs: New page for Shopify (#17793)

* Added shopify ecommerce site

* Better Shopify instructions

* Better heading

* It's an imperative verb, not a noun

* Added shopify-buy

* Cleanup, editing

* Apply suggestions from code review

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* chore(docs): Add "Gentics Mesh" guide (#18506)

* Fix usage of wrong command in graphcms source guide

* Add Gentics Mesh source guide

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Fix formatting

* Apply gatsby style guide

* Simplify wording

* Add Gentics Mesh to list of headless CMS

* Update docs/docs/sourcing-from-graphcms.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Reduce link title length

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* Update docs/docs/sourcing-from-gentics-mesh.md

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* added newly created guide to doc sidebar (#18986)

* test: pin cypress version in some e2e-tests (#18989)

* fix(gatsby): Fix matchpath ordering (#18478)

* Add a test that fails when a * matchpath shadows an index page.

* Trailing * is removed during matchPath page weight scoring, this places glob paths at an equal level to index paths. Test for glob path prescedence now uses `toEqual` for deep object comparison.

* Place all static paths before matchPaths using wildcard sort field before score.

* Test case is more difficult with pages nested more deeply in matchPaths.

* chore(release): Publish

 - gatsby-theme-blog-core@1.0.8
 - gatsby-theme-blog@1.1.8
 - gatsby-theme-notes@1.0.8
 - gatsby@2.17.3

* fix(gatsby): fix hashes used in webpack for output (#18973)

* fix(gatsby): use hashes as module identifiers for webpack caching

* fix(gatsby): disable hmr on production builds for css

* update absolute path to relative ones

* chore(release): Publish

 - gatsby-theme-blog-core@1.0.9
 - gatsby-theme-blog@1.1.9
 - gatsby-theme-notes@1.0.9
 - gatsby@2.17.4

* Don't use "static" to describe what Gatsby does (#18999)

See also https://github.com/gatsbyjs/gatsby/pull/18998

* fix: update minor updates in packages (#18875)

* Don't use "static" to describe what Gatsby does (#18998)

* Don't use "static" to describe what Gatsby does

The word just confuses people as they think you can't do app-y stuff now.

* chore: format

* docs: fix code snippet in working-with-video.md (#19000)

Fixes Video component file.

* feat(gatsby-source-shopify): add SEO field to articles (#18985)

Add seo field to Article query

* chore(starters): Set exit status for default test npm script (#18879)

* Set exit status for default (unimplemented) test command

* Set exit status for default test command in default starter

* Set exit status for default test command in blog starter

* Added Gatsby-Docs-Kit to Gatsby tools section (#19005)

* docs: clarify that `loader.js` is a function by calling it in… (#19008)

This change makes it a bit more obvious that `loaders.js` is a function and should be called.

* docs: Update storybook 5.* configuration (#19006)

* Update storybook 5.* configuration

The config can be simplified as seen in https://storybook.js.org/docs/guides/guide-react/#step-3-create-the-config-file

* chore: format

* fix(gatsby-plugin-mdx): don't use jsx (#18982)

* fix: don't use jsx

* chore: format

* fix(gatsby): Remove internal Node modules in getNonGatsbyCallS… (#19009)

* Remove internal Node modules in getNonGatsbyCallSite

* Update packages/gatsby/src/utils/stack-trace-utils.js

Co-Authored-By: Michal Piechowiak <misiek.piechowiak@gmail.com>

* chore(docs): Clarify blog posting approval note (#18941)

* (chore)docs: clarify blog posting approval

Make this language slightly clearer.

* Update docs/contributing/blog-and-website-contributions.md

* [Docs][Recipes]Sourcing from Wordpress (#17374)

* [Docs][Recipes]Sourcing from Wordpress

* Update docs/docs/recipes.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/recipes.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update directions for Sourcing from WordPress

* Include code for post.js

* Update docs/docs/recipes.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* chore: format

* remove extra character for consistency

* remove unneeded query fields and set html

* docs(recipes): using wordpress example (#19014)

* Create post.js

* Create package.json

* Create gatsby-node.js

* Create gatsby-config.js

* Create index.js

* Docs: Example for sourcing from Wordpress

* Docs: Example for sourcing from Wordpress

* Docs: Example for sourcing from Wordpress

* Docs: Example for sourcing from Wordpress

* Create page.js

* Docs: Example for sourcing from Wordpress

* Docs: Example for sourcing from Wordpress

* Docs: Example for sourcing from Wordpress

* Fixed closing tag errors

* Fixed closing tag errors

* Fixed closing tag errors

* chore: format

* Update examples/gatsby-sourcing-wordpress/gatsby-config.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/gatsby-sourcing-wordpress/package.json

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/gatsby-sourcing-wordpress/src/templates/post.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/gatsby-sourcing-wordpress/src/templates/page.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/gatsby-sourcing-wordpress/src/templates/page.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/gatsby-sourcing-wordpress/src/templates/post.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* chore: format

* Update folder name and readme

* Revert "Update folder name and readme"

This reverts commit 5f7481e7a889d3eef6cf00e1e6fcd7f2d5d349b5.

* rename examples

* Update examples/using-wordpress-with-acf/README.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/using-wordpress-with-acf/README.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/using-wordpress-with-acf/gatsby-config.js

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/using-wordpress-with-acf/package.json

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update examples/using-wordpress-with-acf/package.json

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Restore comments

* Restore comments

* chore: format

* fix linting issues

* feat(starter): expand .gitignore in default starter to ignore… (#19015)

* docs: Fix broken links to gatsby blog theme and gatsby notes theme (#19011)

* feat(starters): Update .gitignore in all starters to ignore .env, .env.development, .env.production, etc. (#18968)

* Update '.env' line in .gitignore to '.env*' so that it works for .env.development, .env.production, etc. files

* Update '.env' line in the .gitignore file of other starters to '.env*' so that it works for .env.development, .env.production, etc. files

* feat(site-showcase-validator): check 'source_url' for private… (#18840)

* feat(site-showcase-validator): check 'source_url' for private repositories

* feat(site-showcase-validator): adjust the exit code

* feat(site-showcase-validator): modify the warning message

* chore(gatsby): Move duplicate node path check to gatsby-core-utils (#19017)

* chore(gatsby): Move duplicate node path check to gatsby-core-utils

* chore(gatsby): Rename utility function and add unhappy path to the unit test

* chore(showcase): Add veryben.com (#18996)

* chore(showcase): Update iammatthias.com entry (#18991)

* Update sites.yml

Update listing for https://iammatthias.com

* Update docs/sites.yml

Co-Authored-By: Benjamin Lannon <benjamin@lannonbr.com>

* chore(starters): Add gatsby-starter-point (#18997)

* Remove 'shortcut' link type before 'icon' (#19007)

* chore(www): remove sentry from .org (#19020)

* Fix README.md on nomjs.com by replacing :rocket: with rocket emoji (#19022)

* chore(showcase): Add brentrunsmarathons.com and pedrolatorre.c… (#18987)

* added brentrunsmarathons.com website to sites.yml

* Add pedrolatorre.com and brentrunsmarathons.com

* fixed typo

* chore: format

* fix(gatsby-plugin-netlify): don't add `/undefined` in generated `_headers` file (#18925)

* fix(gatsby-plugin-netlify): /undefined in generated _headers file

* Explicitly check that /undefined is not in output of buildHeadersProgram

* Fix matcher

* Update awesome-gatsby-resources.md (#18915)

* No need of inverted commas here (#18953)

* added Bare Advertising & Communications as creator (#19026)

* core(docs): add better link text (#18910)

* changed some we to you (#18913)

* chore(docs): Fix spellings of frontend, backend, end user (#18958)

* chore(docs): explain shadowing a bit more (#18931)

* Remove appveyor.yml

* chore(docs): explain import vs require (#18930)

* explain import vs require

* Update docs/tutorial/part-two/index.md

* chore(docs): clarify API usage (#18926)

* clarify API usage

* Update docs/tutorial/part-seven/index.md

* Update docs/tutorial/part-seven/index.md

* blog: Update link to shadowing documentation (#18929)

* chore(starters): gatsby-starter-dev-portfolio (#18924)

* chore(starters): gatsby-starter-dev-portfolio

* Update starters.yml

* chore: format

* feat(gatsby-cli): Add command-line argument for logger (#18818)

* Update cli to set logger based on command line argument

* Fix regression for choosing default reporter

* Expose only JSON logger

* updated title (#19041)

removed . from title

* feat(site-showcase-validator): Add user-agent for HTTP requests (#19031)

* feat(site-showcase-validator): Add user-agent for HTTP requests

* Swapped fetch call to wrapper function

* docs(gatsby-source-graphql): Fix English and clarify fieldName and typeName (#18937)

* Fix English and clarify fieldName and typeName

* chore: format

* Apply suggestions from code review

* Updated according to Gatsby Style Guide. (#19040)

Updated according to Gatsby Style Guide. Shifted perspective from the first-person perspective ("I", "we") to the secondary perspective ("you") per the Gatsby Style guide.

* Mention useStaticQuery hook in documentation (#18920)

Adds a mention of the new `useStaticQuery` hook in the Static Query vs. Normal Query documentation. Points users to helpful Gatsby documentation on how to use `useStaticQuery` to query data at build time.

* fix(docs): Sentence fragment in translation docs (#19047)

* Update Our to Your (#19037)

* Update Our to Your

* Add suggestion changes

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* Fix broken link in Themes API reference (#19045)

* chore(showcase): Add kentarom's portfolio to showcase list (#19052)

* Update README.md (#19051)

* Add more context to creating new languages (#19066)

* Add more context to creating new languages

* chore: format

* chore(starters): gatsby-starter-zurgbot (#18907)

* adding gatsby-starter-zurgbot to starters library

* Update docs/starters.yml

Co-Authored-By: Lennart <lekoarts@gmail.com>

* Update docs/starters.yml

Co-Authored-By: Lennart <lekoarts@gmail.com>

* chore: format

* fix weird merge issue


Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Add MDX Blog starter (#18950)

* Update starters.yml

Add a Gatsby Starter

* Update starters.ymsl

* Update docs/starters.yml

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* Update docs/starters.yml

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* Update docs/starters.yml

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* chore: format

* Update docs/starters.yml

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* chore(starters): gatsby-typescript-storybook-starter (#19068)

* add start storybook and ts

* Remove "Netlify" tag


Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(docs): add Language repos to the list (#19069)

* chore(docs): add Polish repo to the list

* add other languages


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(showcase): Add Fuzzy String Matching (#19071)

* Update sites.yml

* delete empty line

* delete incorrect category


Co-authored-by: Lennart <lekoarts@gmail.com>

* chore(starters): update lewis-gatsby-starter-blog (#19076)



Co-authored-by: GatsbyJS Bot <mathews.kyle+gatsbybot@gmail.com>

* fix(www): support dark mode in 'Collapse all' btn on hover (#19062)

* chore(docs): Update pronouns (#19079)

* docs(gatsby-plugin-mdx): fix error in MDXProvider component ref (#19075)

* fix: update minor updates in packages (#19080)

* feat(redirects): allow multiple redirects from same path when they have different options (#19048)

This updates how the redirects reducer prevents duplicates so that it
allows redirects with the same fromPath when the other options are
different.

* chore(docs): Fix unclickable links (#19067)

* chore(showcase): Add MotionThat, TEN ALPHAS, SalesGP and Source Separation Systems (#19073)

* chore(gatsby-image): Add missing type definitions for GatsbyImageProps (#18916)

* Add missing properties to GatsbyImageProps typedef

Added missing properties from Gatsby Image prop types (https://github.com/gatsbyjs/gatsby/blob/3776d39e15368fdd1468d4424c93c8b4ffa3415e/packages/gatsby-image/src/index.js#L660-L685) to TypeScript type definitions of Gatsby Image.

* Add sync comment to GatsbyImage propTypes

* Add sync comment to GatsbyImageWithIEPolyfill propTypes

* Replace paths by GitHub URLs in GatsbyImageWithIEPolyfill comment

* Replace paths by GitHub URLs in GatsbyImage comment

* Update gatsby-docs-translation-guide.md (#19082)

* chore(gatsby-transformer-screenshot): Use createContentDigest helper for file name (#18830)

* update gatsby plugins to use new createContentDigest helper at gatsby-transformer-screenshot & replace peerDependency for gatsby-transformer-sqip

* change to use contentDigest

* Update yarn.lock

* Make changes from review

* Move dependency to right package

* fix(gatsby-cli): handle git commit failures (#18839)

* remove git support if initial commit fails

* add info log when removing git support

* fix(gatsby-dev-cli): Default to no dependencies before running diff (#19085)

* chore(release): Publish

 - gatsby-cli@2.8.6
 - gatsby-core-utils@1.0.16
 - gatsby-dev-cli@2.5.36
 - gatsby-graphiql-explorer@0.2.26
 - gatsby-image@2.2.30
 - gatsby-page-utils@0.0.28
 - gatsby-plugin-emotion@4.1.13
 - gatsby-plugin-guess-js@1.1.22
 - gatsby-plugin-manifest@2.2.24
 - gatsby-plugin-mdx@1.0.54
 - gatsby-plugin-netlify-cms@4.1.26
 - gatsby-plugin-netlify@2.1.23
 - gatsby-plugin-offline@3.0.17
 - gatsby-plugin-page-creator@2.1.28
 - gatsby-plugin-preload-fonts@1.0.15
 - gatsby-plugin-sharp@2.2.33
 - gatsby-plugin-styletron@4.1.17
 - gatsby-plugin-subfont@1.1.14
 - gatsby-plugin-typography@2.3.15
 - gatsby-remark-code-repls@3.0.16
 - gatsby-source-contentful@2.1.51
 - gatsby-source-drupal@3.3.1
 - gatsby-source-filesystem@2.1.34
 - gatsby-source-graphql@2.1.21
 - gatsby-source-lever@2.1.17
 - gatsby-source-mongodb@2.1.19
 - gatsby-source-shopify@3.0.25
 - gatsby-source-wordpress@3.1.45
 - gatsby-telemetry@1.1.34
 - gatsby-theme-blog-core@1.0.10
 - gatsby-theme-blog@1.1.10
 - gatsby-theme-notes@1.0.10
 - gatsby-theme-workspace@1.0.3
 - gatsby-transformer-csv@2.1.15
 - gatsby-transformer-hjson@2.2.18
 - gatsby-transformer-javascript-frontmatter@2.1.16
 - gatsby-transformer-javascript-static-exports@2.2.17
 - gatsby-transformer-json@2.2.16
 - gatsby-transformer-pdf@1.1.17
 - gatsby-transformer-remark@2.6.31
 - gatsby-transformer-screenshot@2.1.37
 - gatsby-transformer-sharp@2.3.1
 - gatsby-transformer-sqip@2.1.37
 - gatsby-transformer-toml@2.2.16
 - gatsby-transformer-xml@2.1.17
 - gatsby@2.17.5

* fix: update minor updates in packages (#19086)

* feat(gatsby-core-utils): Add isCI and getCIName (#19039)

Fixes https://github.com/gatsbyjs/gatsby/issues/19018

* Docs/contributing index to mdx (#19057)

* Converted pages/contributing/index.js to mdx

* Removed rundant h1, it is created by the template from frontmatter title.

* Renamed to index.mdx

* chore(release): Publish

 - gatsby-cli@2.8.7
 - gatsby-core-utils@1.0.17
 - gatsby-plugin-manifest@2.2.25
 - gatsby-plugin-sharp@2.2.34
 - gatsby-source-contentful@2.1.52
 - gatsby-source-drupal@3.3.2
 - gatsby-source-filesystem@2.1.35
 - gatsby-source-shopify@3.0.26
 - gatsby-source-wordpress@3.1.46
 - gatsby-telemetry@1.1.35
 - gatsby-theme-blog-core@1.0.11
 - gatsby-theme-blog@1.1.11
 - gatsby-theme-notes@1.0.11
 - gatsby-transformer-remark@2.6.32
 - gatsby-transformer-sqip@2.1.38
 - gatsby@2.17.6

* fix: update minor updates in packages (#19087)

* [docs] added code blocks to highlight code specific to steps 4 and 5 in Using Gatsby Image doc (#18790)

* added code blocks to highlight code specific to step 4 and 5

* changed queries to useStaticQuery

* fix(www): Eliminate horizontal scroll on mobile devices (#18892)

* fix(www): Make egghead iframe videos responsive (eliminate horizontal scroll on mobile)

* fix: Eliminate linter/prettier errors

* refactor: wrap useCallback around settIframeWidth function

* fix: use VIDEO_RATIO variable instead of magic number

* Update www/src/components/shared/egghead-embed.js

Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>

* chore: format

* chore: Remove Flow (#19028)

* chore(docs): Fix case of GitHub, GitLab, JavaScript, TypeScript and WordPress. (#19091)

* chore: update dependency aws-sdk to ^2.558.0 (#19096)

* Add script to create new translation repositories (#18893)

* add the create script

* description of env

* add reference to comment.

* edit README

* more information in README

* update create script

* add pulling logic

* add maintainers to organization

* add comment

* add discord link

* add more discord references

* Move script explanations to the README

* Update scripts/i18n/README.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* link to translation guide

* Update create.js

* remove style guide from list of scripts

* Fix - Broken link & syntax highlighting on Recipes: Sourcing f… (#19084)

* fix: Broken link and syntax highlighting problem

* Fix broken link

* Correct caching warning footnote about 'no-cache' (#18763)

* Correct caching warning footnote about 'no-cache'

Footnote was incorrectly warning against using 'no-cache', and could use a little additional clarification.

[1]: https://tools.ietf.org/html/rfc7234#section-5.2.2.1
[2]: https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/http-caching#no-cache_and_no-store

* run prettier

* fix(gatsby-plugin-mdx): display better error message for MDX `html` field in development (#19111)

* Update sites.yml (#19107)

* chore(showcase): add leavemealone.app to sites.yml (#19104)

* chore(showcase): add leavemealone.app to sites.yml

* chore(showcase): Updated main_url in sites.yml for leavemealone.app

* format

* chore(showcase): Add open techiz website (#19109)

* open techiz website added to showcase

We use strapi source and host on netlify, we have validated performance and follow all best practices

* Update sites.yml

* format

* chore: format

* chore(docs): Fix case of Drupal, Gatsby and WordPress. (#19100)

* [docs] describe console logging of the build process (#18816)

* describe console logging of the build process

* rephrase build debugging doc

* fix(docs): Fix broken link to Documentation PRs (#19121)

* chore(docs): Add reference guide "Modifying a Starter" (#18995)

* Draft 'Modifying a Starter'

* Link to 'Modifying a Starter' from parent page and tutorial

* Add 'Modifying a Starter' to navigation menu

* Link to Gatsby resources instead of external ones

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Add a dash to ‘e-commerce’

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* link to Gatsby GraphQL resource & correct siteMetadata typo

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Replace folder structure screenshot & correct typos

* Correct 'SiteMetaData' typos in blog post and GraphQL reference

* Update default starter files screenshot

* docs(gatsby-source-mongodb): fix mapping configuration example (#19120)

* Removed extra bracket and added missing comma

* chore: format

* update highlight to focus on changed piece (#18969)

* update highlight to focus on changed piece

* chore: format

* chore(docs): Fix the heading order (#18881)

* fix(docs): Fix the heading order

* Update docs/docs/adding-markdown-pages.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-markdown-pages.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-markdown-pages.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-buttercms.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-buttercms.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/sourcing-from-netlify-cms.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/gatsby-on-linux.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update sourcing-from-buttercms.md

* Update docs/docs/sourcing-from-buttercms.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* chore: format

* [docs] How to manage suggestions section on the How to Open Pull Requests guide (#18745)

* resolves #14598

Adds a reference guide on how to upgrade Gatsby and its dependencies

* Fixed typos and added related content

* Fixed additional typos

* Fixed additional typos, one with the name of the file, added links for the doc-links.yaml file, escaped < and > characters in markdown thata were causing some errors

* Updated title based on @marcysutton suggestions

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Solves suggested changes such as modifying links for relative urls, removing yarn instructions and alignments to Gatsby style guide

* Apply additional suggestions

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Added a section on how to handle reviews on your PR

* Apply suggestions from code review

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* add section on how to change default package manager. (#19098)

* add section on how to change default package manager.

Changing the default package manager used by `gatsby-cli`can be tricky for newcomers as there is no CLI command for this. I've added some explanation to help those who want to change it by modifying the configstore file.

* be more explicit on the purpose of this change

This default package manager change only concerns future projects using gatsby new.

* prettier ok

* Update docs/docs/gatsby-cli.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* chore(docs): p-files Part1 - adjust headlines according to style guide + adjust some texts (#18715)

* production-app: just adjust headlines to fit style guide

* progressive-web-app: adjust some text & headlines - handle Progressive Web App like Markdown in the spelling

* adjust headlines & titles to fit style guide + adjust some texts

* revert a few things

* change Window to

* pixabay-source-plugin-tutorial: replace
Usage: npm <command>

where <command> is one of:
    access, adduser, audit, bin, bugs, c, cache, ci, cit,
    clean-install, clean-install-test, completion, config,
    create, ddp, dedupe, deprecate, dist-tag, docs, doctor,
    edit, explore, get, help, help-search, hook, i, init,
    install, install-ci-test, install-test, it, link, list, ln,
    login, logout, ls, org, outdated, owner, pack, ping, prefix,
    profile, prune, publish, rb, rebuild, repo, restart, root,
    run, run-script, s, se, search, set, shrinkwrap, star,
    stars, start, stop, t, team, test, token, tst, un,
    uninstall, unpublish, unstar, up, update, v, version, view,
    whoami

npm <command> -h  quick help on <command>
npm -l            display full usage info
npm help <term>   search for help on <term>
npm help npm      involved overview

Specify configs in the ini-formatted file:
    /Users/codingcookie/.npmrc
or on the command line via: npm <command> --key value
Config info can be viewed via: npm help config

npm@6.10.3 /usr/local/lib/node_modules/npm with npm

* add requested review changes

* fix(www): Fix Compare with Gatsby button on smaller breakpoints (#19063)

* fix(www): No kebab case for CSS properties in objects (#19129)

* chore(docs): u-files - minor punctuation and grammar fixes (#18762)

* feat(gatsby): enable local themes (#15856)

* chore(release): Publish

 - gatsby-cli@2.8.8
 - gatsby-plugin-manifest@2.2.26
 - gatsby-plugin-mdx@1.0.55
 - gatsby-plugin-sharp@2.2.35
 - gatsby-remark-images-contentful@2.1.21
 - gatsby-source-contentful@2.1.53
 - gatsby-source-drupal@3.3.3
 - gatsby-source-mongodb@2.1.20
 - gatsby-theme-blog-core@1.0.12
 - gatsby-theme-blog@1.1.12
 - gatsby-theme-notes@1.0.12
 - gatsby-transformer-screenshot@2.1.38
 - gatsby-transformer-sharp@2.3.2
 - gatsby-transformer-sqip@2.1.39
 - gatsby@2.17.7

* fix(gatsby-plugin-sharp): fix "Cannot set property 'multipassCount' of undefined" error (#19131)

* chore(release): Publish

 - gatsby-plugin-sharp@2.2.36
 - gatsby-source-contentful@2.1.54
 - gatsby-theme-blog-core@1.0.13
 - gatsby-theme-blog@1.1.13
 - gatsby-transformer-sqip@2.1.40

* chore(www): Import from `gatsby-plugin-theme-ui`… (#19134)

instead of `gatsby-design-tokens`; we're noew only importing from `gatsby-design-tokens` once, in `src/gatsby-plugin-theme-ui`. Refactor a couple (related) things along the way.

Ref. #19115

* chore(docs): Fix two things in partnering doc (#19139)

* chore(docs): fix language for code highlighting from sh to she… (#19135)

* fix(www): /guidelines/color modal title color for dark mode (#19147)

* fix(www): /guidelines/color modal title color

* chore(www): Remove utils/guidelines/theme

* Docs define acronyms (RFC and SEO) (#19148)

* add RFC definition on contributor docs

* add SEO acronym definition

* Update docs/contributing/gatsby-style-guide.md

Co-Authored-By: Amberley <amberleyromo@users.noreply.github.com>

* remove acronym from header

* keep header, but change first sentence

* Use soft line-feeds for Code of Conduct (#19166)

This makes it easier to translate, since the entire paragraph can be translated instead of weird word breaks.

* Correct count of contributors (#19160)

* Update gatsby-docs-translation-guide.md (#19094)

* docs: add adding react components doc (#18651)

* docs: add initial revision of adding react components doc

* docs: add react components doc link to sidebar

* docs(add react components): swap to american spelling

Co-Authored-By: Kyle Gill <kylerobertgill@gmail.com>

* docs(add react components): add info about using third party components

* docs(add react components): remove sections from other pages and cross-reference

* docs(porting from cra): add class component examples for browser global use

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/porting-from-create-react-app-to-gatsby.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/porting-from-create-react-app-to-gatsby.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/porting-from-create-react-app-to-gatsby.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Remove references to other package managers

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/adding-react-components.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>

* Update adding-react-components.md

* Update docs/docs/adding-react-components.md

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>

* chore(docs):capitalization and grammar fixes (#18788)

* capitalization and grammar fixes

* fix docs pr based on feedback

* Use gatsby-theme name convention on getting started (#19154)

* Fix capitalize (#19177)

* Site submission oberion (#19176)

* Submit to site showcase: Oberion

* Remove category gaming

* add hint about how to disable ESLint (#19170)

* chore(examples): Update graphql-reference (#19180)

* chore(showcase): Update site showcase in response to errors in… (#19182)

- Bottender Docs is no longer using Gatsby. Removing entry
- Citywide Holdup's repo is no longer public. Removing source_url
- Dale Blackburn's portfolio repo is no longer public. Removing source_url
- Rou Hun Fan's portfolio repo is no longer public. Removing source_url
- nehalist.io's repo is no longer public. Removing source_url

* chore(docs): fix language for code highlighting and highlight line (#19163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.