Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Gatsby Link's dependency @reach/router version #18600

Closed
wants to merge 2 commits into from

Conversation

@BerlinChan
Copy link

BerlinChan commented Oct 14, 2019

Description

Update Gatsby Link's dependency @reach/router version to 1.2.1.

To fix escape href before check current.

Related Issues

Fixes #18597

BerlinChan added 2 commits Oct 14, 2019
update dependency @reach/router version to 1.2.1, to fix escape href before check current, issuse #18597
update @reach/router version
@BerlinChan BerlinChan requested a review from gatsbyjs/core as a code owner Oct 14, 2019
@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Oct 14, 2019

Gatsby already use ^1.2.1:

"@reach/router": "^1.2.1",

But this change is valid as well, so let's merge it (just not sure if it will actually do anything)

Copy link
Contributor

pieh left a comment

Thanks!

@pieh pieh dismissed their stale review Oct 14, 2019

Actually, we should not bump peerDependency, as this will only mess things up.

@wardpeet

This comment has been minimized.

Copy link
Member

wardpeet commented Oct 14, 2019

@Berlin Chan to fix your issue locally please upgrade gatsby or/and run npm install @reach/router you should have the updated @reach/router package.

@wardpeet wardpeet closed this Oct 14, 2019
@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Oct 14, 2019

The issue is that PR that was linked in the issue was not yet released in stable version. @reach/router@1.2.1 was released over year ago and it doesn't contain that change, so there is no proper fix available yet, until new stable is released.

You might try using Yarn resolutions you can add following to your package.json to use beta version which contains the fix:

  "resolutions": {
    "@reach/router": "1.3.0-beta.0"
  },
@BerlinChan

This comment has been minimized.

Copy link
Author

BerlinChan commented Oct 15, 2019

@pieh I see! The commit was not contained in version 1.2.1. Sorry, my fault.

Your Yarn resolutions config method FIX my problem, thank you all! The Great Gatsby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.