Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): create page dependencies from contextual node model methods even if no path is passed #18650

Merged

Conversation

@nickyfahey
Copy link
Contributor

nickyfahey commented Oct 14, 2019

Description

Makes sure ContextualNodeModel methods that can create page dependencies get the path from the context if it is not passed in the pageDependencies arg.

Related Issues

#18579

@nickyfahey nickyfahey requested a review from gatsbyjs/core as a code owner Oct 14, 2019
@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Oct 15, 2019

Failing test is not related to your changes and was fixed in master sometime yesterday. When you have a chance, please merge master in again to resolve that

Copy link
Contributor

freiksenet left a comment

This is great!

Thank you very much! 💜

@gatsbybot gatsbybot merged commit 3d38af2 into gatsbyjs:master Oct 15, 2019
21 checks passed
21 checks passed
Danger All good
Details
Peril All green. Nice work.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 67 tests passed in 00:29
Details
unit_tests_windows Build #20191015.42 succeeded
Details
@nickyfahey nickyfahey deleted the nickyfahey:topics/auto-path-page-dependency branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.