Bump css-loader #20654
Bump css-loader #20654
Conversation
|
Did you run I'm not comfortable with the webpack change so I'm leaving that to somebody else to review (@wardpeet?) |
| modules: { | ||
| mode: `local`, | ||
| localIdentName: `[name]--[local]--[hash:base64:5]`, | ||
| }, |
There was a problem hiding this comment.
These changes are all accurate for css-loader@3. E.g. there is no /locals file anymore, camelCase was changed to localsConvention, modules is setup correctly.
One thing I'm seeing here, that's old behavior but something that we could improve is to change the localIdentName to just a hash when we're building for production (unless that's already done via some other mechanism). I'm not arguing for that to be in this PR, just stating so we can track it.
|
@pvdz I just uploaded now |
There was a problem hiding this comment.
Sadly we cannot upgrade to this version as it requires node 8.9.0. Gatsby requires node 8.0.0 to run.
also css-loader version 2 & 3 have some internal behaviour changes that cannot be fixed by remapping option key/values so we potentially could break people websites.
see https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#breaking-changes-1 & https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#breaking-changes for more info
| localIdentName: `[name]--[local]--[hash:base64:5]`, | ||
| localsConvention: `dashesOnly`, | ||
| modules: { | ||
| mode: `local`, |
There was a problem hiding this comment.
| mode: `local`, | |
| mode: false, |
wardpeet
added
the
breaking change
|
Closing for now as we can't upgrade at this point. |
|
@wardpeet Can you tell me plan of solving this problem? |
|
@item4 we expect to bump to node 10 in about one or two weeks. After that this should be viable, provided the node minversion was the only blocker. |
|
@pvdz sorry. I don't know well. |
|
Fwiw, we've bumped the node version so we can try this now... |
|
@item4 can you please update the PR (or close this and create a new one) based on the current master? Since we've updated to Node 10 we can now bump this package. Thanks! |
|
I got it. I will fix confilct asap. |
|
@pvdz I resolved merge conflict. but it had some problems yet.
So I guess this PR will be fail in CI |
|
Ok yeah. Bumping webpack is non-trivial so I don't see that happening right now. Guess I'll close this again, sorry about that. Thanks for trying! |
Description
This PR bump version of css-loader of gatsby for fix broken escaping and spaces in css
Documentation
nothing, just bump css-loader and change configration for newer version
Related Issues