Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www) reorganize contributing section #21806

Merged
merged 6 commits into from Feb 28, 2020
Merged

Conversation

@tesseralis
Copy link
Collaborator

tesseralis commented Feb 28, 2020

Description

  • Split up blog-and-website-contributions into blog-contributions and website-contributions.
  • docs-and-website-components -> docs-and-blog-components
    • move website specific section on theme-ui to website-contributions.
  • Update links.

I wanted a specific "Website contributions" site so I can put in more information about how to work with translations, the different site sections/layout, etc.

Fixes: #21320

@tesseralis tesseralis requested review from AishaBlake and gillkyle Feb 28, 2020
@tesseralis tesseralis requested review from gatsbyjs/core as code owners Feb 28, 2020
www/redirects.yaml Outdated Show resolved Hide resolved
tesseralis and others added 3 commits Feb 28, 2020
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
…/gatsby into reorganize-contributing
Copy link
Contributor

gillkyle left a comment

I think this reorganization is a great idea! I pulled it locally to click through the links and didn't see any problems, and since it is mostly moving content I don't see why this shouldn't be merged 👍

@@ -138,3 +138,7 @@
# redirecting gatsby-source-filesystem Programmatic Import to plugin README
- fromPath: /docs/gatsby-source-filesystem-programmatic-import/
toPath: /packages/gatsby-source-filesystem/
- fromPath: /contributing/blog-and-website-contributions/

This comment has been minimized.

Copy link
@gillkyle

gillkyle Feb 28, 2020

Contributor

Nothing to change here, just commenting to say how much more I still appreciate this compared to the enormous list of createRedirects that used to be in the gatsby-node 😅

@gillkyle gillkyle merged commit 12324a8 into master Feb 28, 2020
23 of 24 checks passed
23 of 24 checks passed
Cloud Tests
Details
TypoCheck Found a few typos
Details
Danger All good
Details
Gatsby Build Service Gatsby Build Service
Details
Gatsby Build Service Gatsby Build Service
Details
Peril All green. Well done.
Details
build-test Workflow: build-test
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
@gillkyle gillkyle deleted the reorganize-contributing branch Feb 28, 2020
@gatsbyjs gatsbyjs deleted a comment from muescha Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.