Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): remove yarn.lock from gitignore #22196

Merged
merged 3 commits into from Mar 12, 2020

Conversation

@snitin315
Copy link
Member

snitin315 commented Mar 12, 2020

Description

Removed yarn.lock from .gitignore

Related Issues

Fixes #22072

@snitin315 snitin315 requested a review from gatsbyjs/core as a code owner Mar 12, 2020
@snitin315 snitin315 force-pushed the snitin315:chore/gitignore branch from 787eb3f to f57f44a Mar 12, 2020
@pieh

This comment has been minimized.

Copy link
Contributor

pieh commented Mar 12, 2020

We want only root level yarn.lock not to be ignored - all others should be ignored, so if you could adjust .gitignore for that, it would be awesome!

@snitin315 snitin315 force-pushed the snitin315:chore/gitignore branch from f57f44a to 1da8a5b Mar 12, 2020
@snitin315

This comment has been minimized.

Copy link
Member Author

snitin315 commented Mar 12, 2020

@pieh Done 💯

pieh added 2 commits Mar 12, 2020
@pieh
pieh approved these changes Mar 12, 2020
Copy link
Contributor

pieh left a comment

Thanks

@gatsbybot gatsbybot merged commit 94f789e into gatsbyjs:master Mar 12, 2020
21 of 22 checks passed
21 of 22 checks passed
Cloud Tests
Details
Danger All good
Details
Peril All green. Congrats.
Details
TypoCheck No typos found
Details
build-test Workflow: build-test
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
@snitin315 snitin315 deleted the snitin315:chore/gitignore branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.