Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node min version to 10.13.0 #22400

Merged
merged 14 commits into from Mar 20, 2020
Merged

chore: bump node min version to 10.13.0 #22400

merged 14 commits into from Mar 20, 2020

Conversation

@freiksenet
Copy link
Contributor

freiksenet commented Mar 19, 2020

Node 8 reached end of life in December of 2019. There were deprecation warnings about it in previous Gatsby versions. Less than 3% of Gatsby users are still using Node 8. Some libraries that Gatsby or Gatsby plugins depend on have dropped Node 8. This meant that we were locked into using an older version of packages and couldn’t apply the latest bugfixes (that was a case with, e.g., sharp or got). Some performance and memory improvements were only possible with newer versions of Node too.

Evaluating all those factors, we decided that it’s better to drop Node 8 support in a minor version, rather than wait further.

@freiksenet freiksenet requested review from gatsbyjs/core as code owners Mar 19, 2020
@wardpeet

This comment has been minimized.

Copy link
Member

wardpeet commented Mar 19, 2020

Can we explicitly set circleci to test 10.13 so we don't have regressions when upgrading packages.

@wardpeet

This comment has been minimized.

Copy link
Member

wardpeet commented Mar 19, 2020

Sorry mostly talking about

default: "10"

@pvdz

This comment has been minimized.

Copy link
Contributor

pvdz commented Mar 19, 2020

The changes lgtm. I think this PR is more about what's missing but I think we're looking good...

freiksenet and others added 7 commits Mar 19, 2020
Copy link
Member

wardpeet left a comment

Do we need .yarn/releases/yarn-1.21.0.js in our repo? It's an extra 5mb

@freiksenet

This comment has been minimized.

Copy link
Contributor Author

freiksenet commented Mar 20, 2020

@wardpeet Yes if we want to make sure Yarn is of correct version.

@wardpeet wardpeet changed the title Drop node 8 chore: bump node min version to 10.13.0 Mar 20, 2020
@wardpeet

This comment has been minimized.

Copy link
Member

wardpeet commented Mar 20, 2020

why don't we install it in circleci instead?

Co-Authored-By: Dan Kirkham <herecy@live.co.uk>
Copy link
Member

wardpeet left a comment

LGTM! Added a few typo fixes and @herecydev also caught one.

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@freiksenet freiksenet merged commit 83d681a into master Mar 20, 2020
21 of 23 checks passed
21 of 23 checks passed
build-test Workflow: build-test
Details
ci/circleci: starters_validate Your tests failed on CircleCI
Details
TypoCheck Found a few typos
Details
Cloud Tests
Details
Danger All good
Details
Gatsby Build Service Gatsby Build Service
Details
Peril All green. Well done.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 139 tests passed in 02:53
Details
@delete-merged-branch delete-merged-branch bot deleted the drop-node-8 branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.