Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark repositories and CircleCI config #22445

Merged
merged 2 commits into from Mar 20, 2020

Conversation

@duffn
Copy link
Member

duffn commented Mar 20, 2020

Description

  • Add the NUM_PAGES environment variable to the install step for benchmark runs in CircleCI. This is needed when generating the benchmark pages.
  • Add .nvmrc to benchmark sites to run proper Node version in Netlify and Gatsby Cloud.

Documentation

None.

Related Issues

None.

@duffn duffn requested a review from gatsbyjs/core as a code owner Mar 20, 2020
@duffn duffn changed the title Add NUM_PAGES environment variable to benchmark install step Update benchmark repositories and CircleCI config Mar 20, 2020
Copy link
Member

wardpeet left a comment

LGTM! Good job! 👍

@wardpeet wardpeet merged commit d305364 into gatsbyjs:master Mar 20, 2020
20 of 21 checks passed
20 of 21 checks passed
ci/circleci: starters_validate Your tests failed on CircleCI
Details
Cloud Tests
Details
Danger All good
Details
Peril All green. Yay.
Details
TypoCheck No typos found
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 139 tests passed in 02:59
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.