Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-google-analytics) Add missing deps #22518

Merged
merged 1 commit into from Mar 25, 2020
Merged

chore(gatsby-plugin-google-analytics) Add missing deps #22518

merged 1 commit into from Mar 25, 2020

Conversation

item4
Copy link
Contributor

@item4 item4 commented Mar 23, 2020

Description

This PR add deps what used in code but not included in packages.json

Documentation

Nope

Related Issues

Nope

@item4 item4 requested a review from a team as a code owner March 23, 2020 23:32
@item4
Copy link
Contributor Author

item4 commented Mar 23, 2020

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit c6a01e9 into gatsbyjs:master Mar 25, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 25, 2020

Holy buckets, @item4 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@item4 item4 deleted the gatsby-plugin-google-analytics branch March 25, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants