Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-plugin-twitter): Add pluginOptionsSchema validation #27601

Merged
merged 3 commits into from Nov 13, 2020
Merged

chore(gatsby-plugin-twitter): Add pluginOptionsSchema validation #27601

merged 3 commits into from Nov 13, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

Description

Just like @mxstbr did in #27356

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 22, 2020
@ascorbic ascorbic added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 22, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the plugin-twitter/add-pluginOptionsSchema-validation branch 2 times, most recently from 3b89985 to 0265555 Compare October 22, 2020 23:39
@mxstbr mxstbr mentioned this pull request Oct 27, 2020
Merged
@MichaelDeBoey MichaelDeBoey force-pushed the plugin-twitter/add-pluginOptionsSchema-validation branch from 0265555 to 6373db3 Compare October 28, 2020 12:55
@MichaelDeBoey MichaelDeBoey requested a review from a team as a code owner October 28, 2020 12:55
mxstbr
mxstbr previously approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@mxstbr mxstbr added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 4, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the plugin-twitter/add-pluginOptionsSchema-validation branch from 93285d6 to bd1cea3 Compare November 9, 2020 01:26
mxstbr
mxstbr approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same flakey tests as always that are failing, unrelated to this PR: #27781. Shipping!

@gatsbybot gatsbybot merged commit bf6624b into gatsbyjs:master Nov 13, 2020
@MichaelDeBoey MichaelDeBoey deleted the plugin-twitter/add-pluginOptionsSchema-validation branch November 13, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MichaelDeBoey @mxstbr @ascorbic @gatsbybot