perf(develop): don't use debug config for bluebird #28957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: scaling builds
and removed
status: triage needed
vladar
approved these changes
Jan 11, 2021
vladar
pushed a commit
that referenced
this pull request
Jan 12, 2021
* perf(develop): don't use debug config for bluebird * Update api-runner-node.js (cherry picked from commit 125f571)
gatsbybot
pushed a commit
that referenced
this pull request
Jan 13, 2021
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
gatsby developwe use debug build ofbluebirdcurrently which adds quite significant overhead. This is particularly visible on larger sites with large amount of nodes when we spawn tens of thousandsonCreateNoderuns.gatsby developwas crashing with OOM error. This change allow to not hit this crash without adjusting--max_old_space_size.--max_old_space_size=10000before and after this change - source nodes step drops from ~67.87s (average across 3 runs) to ~21.7s (average across 3 runs)Related Issues
Fixes #28916
Fixes datocms/gatsby-source-datocms#123
Fixes datocms/gatsby-source-datocms#134
[ch21729]