Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-preact): enable error-overlay #30613

Merged
merged 3 commits into from Apr 29, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Apr 1, 2021

Description

Preact has it's own fast-refresh implementation (prefresh). It wasn't working with our implementation.
It now supports custom overlays.

compile error - syntax
compile error - module not found
runtime -error

Documentation

Related Issues

Fixes #25345

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 1, 2021
@wardpeet wardpeet added topic: preact* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 1, 2021
@wardpeet wardpeet merged commit 0dee367 into master Apr 29, 2021
@wardpeet wardpeet deleted the fix/preact-error-overlay branch April 29, 2021 11:17
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-preact] runtime errors don't show up
4 participants